Skip to content

Remove trailing parenthesis from GenerateResxSource#4611

Merged
ericstj merged 1 commit into
masterfrom
ericstj-patch-1
Jan 9, 2020
Merged

Remove trailing parenthesis from GenerateResxSource#4611
ericstj merged 1 commit into
masterfrom
ericstj-patch-1

Conversation

@ericstj
Copy link
Copy Markdown
Member

@ericstj ericstj commented Jan 9, 2020

Fixes regression from #2208

@ericstj ericstj requested review from rladuca, safern and tmat January 9, 2020 00:37
@tmat
Copy link
Copy Markdown
Member

tmat commented Jan 9, 2020

Thanks for fixing!

@tmat
Copy link
Copy Markdown
Member

tmat commented Jan 9, 2020

@riarenas It would be good to add some resources to the arcade validation repo, so that we have better coverage of this code.

@ericstj ericstj added the auto-merge Automatically merge PR once CI passes. label Jan 9, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jan 9, 2020

Hello @ericstj!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link
Copy Markdown

ghost commented Jan 9, 2020

@riarenas It would be good to add some resources to the arcade validation repo, so that we have better coverage of this code.

Yep, makes sense to me. #4612

@ericstj ericstj merged commit 96a4497 into master Jan 9, 2020
@ericstj ericstj deleted the ericstj-patch-1 branch January 9, 2020 20:25
agocke pushed a commit that referenced this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Automatically merge PR once CI passes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants