Fix identifiers generated from resx resource names

[tmat]

No description provided.

[tmat]

@ericstj

[ericstj]

We intentionally didn't do this for CoreFx because we want folks to use resource IDs that are valid identifiers rather than have some transformation that has to be reversed when translating between identifier and resource ID. Does someone have a valid scenario for a resource ID that must be illegal identifier syntax?

[tmat]

The problem is that we have tons of existing resources. Switching Roslyn from the default resource generation to Arcade's produced bad source files. Some resource names used in Roslyn have . in the names.

Alternatively we could report error and change the resx files. Then we would need pretty much the same logic.

[ericstj]

I see. IMHO I'd prefer an error, that way you let a human choose the identifier they want in their source, but I don't feel too strongly about it.

[ericstj]

This is failing to build: missing internals visible to?

[jonfortescue]

@tmat -- what is the status on this?

[tmat]

I don't have bandwidth to finish this right now. Will get back to it later.

[jonfortescue]

@tmat -- just poking again to see how this is going. Do you think you'll be picking this back up soon? If not, I think we probably ought to close it.

[tmat]

Keep it open please.

[mmitche]

@tmat Should we keep this open?

[tmat]

Yes please. I'll get back to it some day.

[rladuca]

@tmat WPF seems broken by this (See https://dev.azure.com/dnceng/public/_build/results?buildId=475850&view=results)

Our generated resource files have bad const string lines like this:

/// <summary>Value of {0} is outside of the allowed range.</summary>
internal const string @ArgumentOutOfRange = "ArgumentOutOfRange");
/// <summary>The value of {0} cannot be changed while the inertia processor is running.</summary>
internal const string @CannotChangeParameterDuringInertia = "CannotChangeParameterDuringInertia");

FYI @vatsan-madhavan

[ericstj]

@tmat seems like missed removing trailing parentheses here:

arcade/src/Microsoft.DotNet.Arcade.Sdk/src/GenerateResxSource.cs

Line 142 in 48bae09

strings.AppendLine($"{memberIndent}internal const string @{identifier} = \"{name}\");");

I'll create a PR to fix this.

[tmat]

Yes, my bad! I tested my change and then I did one "minor" tweak and did not test it again - because it was "just" a minor tweak :-|