Fix identifiers generated from resx resource names (#2208)#5151
Conversation
* Fix identifiers generated from resx resource names * Make AggressiveInlining NET20 conditional (cherry picked from commit 7af51d4)
|
This should be fine. Before merging though, could you fill out https://github.com/dotnet/arcade/blob/master/Documentation/Policy/AskModeTellModeTemplate.md from https://github.com/dotnet/arcade/blob/master/Documentation/Policy/AskTellMode.md please? |
|
cc/ @mmitche |
|
@markwilkie I can't really speak to any of this, as I didn't author the change. Maybe @tmat knows the answer to these questions? |
|
I presume you mean the questions in the template @agocke ? If so, answering them with the context of why you need this backported is sufficient. |
DescriptionBackporting Arcade 5.0 resource generation to 3.X. Customer ImpactRoslyn will not be able to ship on a servicing-capable Arcade for the 3.X SDKs. RegressionNo, although since we had already moved to 5.0, this is effectively a regression in our functionality. RiskUnknown WorkaroundsThe code we used before 5.0 doesn't seem to work anymore. We would have to rewrite this logic into some other package and put it into Roslyn. |
|
@mmitche @markwilkie One of you will have to merge this, since I don't have permissions. |
4 participants
Fix identifiers generated from resx resource names
Make AggressiveInlining NET20 conditional
(cherry picked from commit 7af51d4)