Skip to content

Port two more fixes#5162

Merged
mmitche merged 2 commits into
release/3.xfrom
port-two-fixes
Mar 31, 2020
Merged

Port two more fixes#5162
mmitche merged 2 commits into
release/3.xfrom
port-two-fixes

Conversation

@agocke
Copy link
Copy Markdown
Member

@agocke agocke commented Mar 31, 2020

Description

Two more fixes to resource generation that weren't included in #5151

Customer Impact

Current version of the generator creates invalid VB.

Regression

No

Risk

Unknown

Workarounds

None

@agocke agocke changed the base branch from master to release/3.x March 31, 2020 07:25
@agocke agocke requested review from markwilkie and mmitche March 31, 2020 07:26
@agocke
Copy link
Copy Markdown
Member Author

agocke commented Mar 31, 2020

FYI @markwilkie looks like there were some fixes that weren't included in that PR. I've grabbed all commits that touch resource generation since then (just these two).

@agocke
Copy link
Copy Markdown
Member Author

agocke commented Mar 31, 2020

If there are some docs on how to use a locally built arcade I could test this out first

@mmitche
Copy link
Copy Markdown
Member

mmitche commented Mar 31, 2020

If there are some docs on how to use a locally built arcade I could test this out first

I don't know about docs, but here is what I do:

  1. In your arcade repo, do .\build.cmd -pack
  2. In your target repo, change the arcade references (global.json and Versions.Props) to the version of the arcade packages
  3. In your target repo nuget,config, add an entry for the directory the nuget packages from step 1 were built do.
  4. Build and test as you need.
  5. When iterating, it's important to clean the target repo's package cache

@tmat
Copy link
Copy Markdown
Member

tmat commented Mar 31, 2020

I just overwrite the current version in the package cache for faster iteration. Of course, when I'm done i delete it.

@agocke
Copy link
Copy Markdown
Member Author

agocke commented Mar 31, 2020

@markwilkie @mmitche This appears to build locally now

@mmitche mmitche merged commit 778722a into release/3.x Mar 31, 2020
@agocke agocke deleted the port-two-fixes branch March 31, 2020 18:56
@agocke agocke mentioned this pull request Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants