Upgrade Pdb2Pdb version#5184
Merged
Merged
Conversation
Pdb2Pdb had its command /verbose line option removed (or perhaps it did not exist but did not fail when an unrecognized option was present before) and this broke the target when we updated the version of Pdb2Pdb we were using. (cherry picked from commit 44214d4)
tmat
reviewed
Apr 2, 2020
| <MicrosoftNetFrameworkReferenceAssembliesVersion Condition="'$(MicrosoftNetFrameworkReferenceAssembliesVersion)' == ''">1.0.0-preview.2</MicrosoftNetFrameworkReferenceAssembliesVersion> | ||
| <MicrosoftVSSDKBuildToolsVersion Condition="'$(MicrosoftVSSDKBuildToolsVersion)' == ''">15.1.192</MicrosoftVSSDKBuildToolsVersion> | ||
| <MicrosoftDiaSymReaderPdb2PdbVersion Condition="'$(MicrosoftDiaSymReaderPdb2PdbVersion)' == ''">1.1.0-beta1-62506-02</MicrosoftDiaSymReaderPdb2PdbVersion> | ||
| <MicrosoftDiaSymReaderPdb2PdbVersion Condition="'$(MicrosoftDiaSymReaderPdb2PdbVersion)' == ''">1.1.0-beta2-19575-01</MicrosoftDiaSymReaderPdb2PdbVersion> |
Member
There was a problem hiding this comment.
Not the latest 1.1.0-beta2-20115-01?
Member
Author
There was a problem hiding this comment.
That package doesn't seem to exist on the dnceng feed https://dev.azure.com/dnceng/public/_packaging?_a=package&feed=dotnet-eng&package=Microsoft.DiaSymReader.Pdb2Pdb&protocolType=NuGet&version=1.1.0-beta2-19575-01&view=versions
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Got it, thanks. I'll use that.
Member
There was a problem hiding this comment.
I have unlisted the old version to avoid confusion. Earlier we published everything to a single feed, but these are not tools specific to internal infrastructure so they should be in the tools feed.
Member
Member
Author
|
@tmat Anything else? |
tmat
approved these changes
Apr 2, 2020
mmitche
approved these changes
Apr 2, 2020
Member
Author
|
@mmitche @markwilkie ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in #5162 let me build successfully, but symbol publishing failed because the Pdb2Pdb tool is out of date.