Prevent double-import warning for Microsoft.Common.props

[MattGal]

Noted from the conversation here

[dougbu]

I was about to do the same thing 😺

[alexperovich]

This.... shouldn't really be needed at all. A helix sdk project doesn't use the 'Microsoft.NET.Sdk' and projects made with the helix sdk shouldn't ever import it.

[dougbu]

@alexperovich without this conditionality, features such as automated .NET SDK installation on Helix agents are pretty much useless. We need to know $(NETCoreSdkVersion) when setting $(DotNetCliVersion) and using $(IncludeDotNetCli). That means we need to import all of the .NET SDK's SDK.props, not the small part of it the Helix SDK imports.

[MattGal]

@alexperovich without this conditionality, features such as automated .NET SDK installation on Helix agents are pretty much useless. We need to know $(NETCoreSdkVersion) when setting $(DotNetCliVersion) and using $(IncludeDotNetCli). That means we need to import all of the .NET SDK's SDK.props, not the small part of it the Helix SDK imports.

I think @alexperovich is suggesting full deletion of the line. I prefer to not find out that we did actually need it later on, but I'll chat w/ Alex offline and get this done one way or the other.

[alexperovich]

I am not suggesting full deletion of the line. The helix sdk requires microsoft.common.props and targets to work. It is not designed to work alongside another SDK that also imports them. We can add this condition, but there are no guarantees that anything will work in that scenario.

[dougbu]

What alternative do you suggest @alexperovich to make $(IncludeDotNetCli) useful (without ugly hacks and manual changes to multiple files when the SDK version changes)❔

[MattGal]

After discussion with @alexperovich it seems that it's preferable for teams needing to do this to suppress the warning, abandoning.

[dougbu]

Why is it preferable to suppress the warning❔ I thought @alexperovich was saying what we need to do won't work and we might as well give up on $(IncludeDotNetCli) until something else changes.

[alexperovich]

It looks like we can grab that version without importing the entire sdk. I will look into it.

[dougbu]

I will look into it.

Much appreciated❕

[alexperovich]

#5748