Change Helix Sdk IncludeDotNetCli default to the version used to build#5748
Conversation
| <DotNetCliPackageType Condition=" '$(DotNetCliPackageType)' == '' ">runtime</DotNetCliPackageType> | ||
| <DotNetCliVersion Condition=" '$(DotNetCliVersion)' == '' AND '$(DotNetCliPackageType)' == 'runtime' ">2.1.5</DotNetCliVersion> | ||
| <DotNetCliVersion Condition=" '$(DotNetCliVersion)' == '' AND '$(DotNetCliPackageType)' == 'sdk' ">2.1.403</DotNetCliVersion> | ||
| <DotNetCliPackageType Condition=" '$(DotNetCliPackageType)' == '' ">sdk</DotNetCliPackageType> |
There was a problem hiding this comment.
I couldn't find any "This is the runtime version for this sdk" in the properties. In order to make this work using the current sdk version as the default I had to switch it to using "sdk" rather than "runtime". That isn't a full break because the sdk can do anything the runtime can do.
There was a problem hiding this comment.
There's a $(BundledNETCoreAppPackageVersion) property to get the runtime bundled with the current SDK.
There was a problem hiding this comment.
Is that the version that can be passed to dotnet-install.ps1 when installing the runtime? If so I can use that.
There was a problem hiding this comment.
Yep! dotnet/runtime uses it as the value of DotNetCliVersion for the CoreCLR Helix test runs.
There was a problem hiding this comment.
Done, i've switched the default back to 'runtime' and it chooses the right property based on that.
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Am I correct this won't be validated completely until the change is merged and we update the Arcade versions in dotnet/aspnetcore#23585❔ (Regular validation ring would help only if another repo is already using $(IncludeDotNetCli) and not setting $(DotNetCliVersion).)
|
I validated it locally, and the PR build will use it. |
ghost
mentioned this pull request
4 participants
No description provided.