Use short component names for native files#6617
Use short component names for native files#6617am11 wants to merge 1 commit intodotnet:masterfrom am11:feature/native-naming
Conversation
|
cc @jkoritzinsky, @ViktorHofer, we can delete the workaround https://github.com/dotnet/runtime/blob/93cbc0974aa0475c586f40645e5b58a4b08ef017/eng/native/naming.props#L48-L53 after the subsequent arcade update. |
|
@ViktorHofer, any thoughts on this one? 🙂 |
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
Are these properties documented to be required when consuming the SharedFramework.Sdk? This package is/will also be used by windowsdesktop and aspnetcore.
|
It seems like these properties are not documented and not defined in aspnetcore repo. They are, however, defined in https://github.com/dotnet/windowsdesktop/blob/cc54c39/pkg/Directory.Build.props#L186-L216 as part of the initial port dotnet/windowsdesktop#1 from core-setup. |
|
@jkoritzinsky I guess only windowsdesktop uses this SDK besides dotnet/runtime currently? Are you fine with the change? Sounds like we need to react to it in dotnet/windowsdesktop. |
|
I can/will update windowsdesktop subsequently. :) |
2 participants
In runtime repo, property names for native files components have been unified in https://github.com/dotnet/runtime/blob/93cbc0974aa0475c586f40645e5b58a4b08ef017/eng/native/naming.props. This PR matches the naming.