Skip to content

Migrate WindowsDesktop code from dotnet/core-setup to dotnet/windowsdesktop#1

Merged
dagood merged 9 commits intomasterfrom
dev/migrate
Oct 3, 2019
Merged

Migrate WindowsDesktop code from dotnet/core-setup to dotnet/windowsdesktop#1
dagood merged 9 commits intomasterfrom
dev/migrate

Conversation

@dagood
Copy link
Member

@dagood dagood commented Oct 3, 2019

Copies the code producing the Microsoft.WindowsDesktop.App shared framework from Core-Setup to the WindowsDesktop repo. For https://github.com/dotnet/core-setup/issues/5732.

Known non-blocking issues:

Next steps are to get the official build running, plugged into BAR, and change Core-SDK to consume this repo's outputs rather than Core-Setup. Then Core-Setup should be able to remove its WindowsDesktop build and dependencies.

I tried to split the commits up to highlight interesting changes. The last one has the change to the shared framework tooling SDK and fixes to make everything work.

/cc @jaredpar @vatsan-madhavan @zsd4yr

dagood added 4 commits October 2, 2019 22:21
This is a squashed mix of changes that make the infra use the new sharedfx tooling SDK, trim out obviously unnecessary code, and build bits that seem to work.

Unfortunately, this does contain a few segments that are copied from Core-Setup. Because the directory structure of this repo is different, some files don't exist, so the contents had to move to an existing file.
@dagood dagood self-assigned this Oct 3, 2019
@dagood dagood requested a review from MichaelSimons October 3, 2019 16:55
@dagood
Copy link
Member Author

dagood commented Oct 3, 2019

Added a couple of publish fixes from official build testing.

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I just have a few minor comments.

@dagood
Copy link
Member Author

dagood commented Oct 3, 2019

Good validation build, https://dev.azure.com/dnceng/internal/_build/results?buildId=375827, table:

Platform Master
Windows (x64)
Installer (Checksum)
zip (Checksum)
Windows (x86)
Installer (Checksum)
zip (Checksum)

(This showed me a few issues with the actual readme link table--pushed fixes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants