This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove WindowsDesktop from Core-Setup, now dotnet/windowsdesktop#8494
Merged
dagood merged 3 commits intodotnet:masterfrom Oct 7, 2019
Merged
Remove WindowsDesktop from Core-Setup, now dotnet/windowsdesktop#8494dagood merged 3 commits intodotnet:masterfrom
dagood merged 3 commits intodotnet:masterfrom
Conversation
Member
Author
|
Already deleted this with the second commit. 😄 4178fd8 Leaving this in actually causes a failure, as it should.
This file will be deleted when I switch Core-Setup to the tooling package, no need to clean up refs in that dir. https://github.com/dotnet/core-setup/issues/4787 |
MichaelSimons
approved these changes
Oct 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shared framework will now be produced from dotnet/windowsdesktop instead of this repo. https://github.com/dotnet/core-setup/issues/5732.
The removed files here were already copied over by dotnet/windowsdesktop#1.
I have an example Core-SDK PR to change where it gets the WD sharedfx from from over at dotnet/installer#5161.