Use nethost.dll to find dotnet in ANCM#10829
Conversation
natemcmaster
left a comment
There was a problem hiding this comment.
Changes LGTM. If it works, ![]()
|
Got a slight block on dotnet/core-setup#6672 |
77d5007 to
151528a
Compare
151528a to
7d8e498
Compare
|
@BrennanConroy this is now ready for review. No rush though, I know SignalR + Npm is higher priority. |
|
Re-adding a blocked label to this. I believe there is a fundamental issue with nethost.dll where it can't accept a path to dotnet. This will break anyone who doesn't specify DOTNET_ROOT, DOTNET_HOME, or dotnet on the path and pass in an absolute path to dotnet. |
|
This will be mostly unblocked by dotnet/core-setup#7020 once we update dependencies. We will need to keep our logic to find where dotnet is if it is only available via the path. We can still feed the dotnet location to nethost.dll to find hostfxr, but nethost will not path probe. Here is some pseudo code for how we would find dotnet now:
|
d459428 to
2ed35d2
Compare
|
Closing for now, will reopen one day.... |
Fixes #8838