This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Export unmangled name for get_hostfxr_path on nethost (Windows x86)#6672
Merged
Conversation
elinor-fung
force-pushed
the
nethost-unmangledExport
branch
from
9a20e4f to
d9570d9
Compare
elinor-fung
changed the title
sdmaclea
reviewed
Jun 5, 2019
sdmaclea
left a comment
sdmaclea
left a comment
There was a problem hiding this comment.
Not sure how the tests relate to the export?
Member
Author
|
@sdmaclea The changes to tests basically add checking that the exports are as we want and consuming |
vitek-karas
approved these changes
Jun 5, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…otnet/core-setup#6672) * Use .def file for exports Commit migrated from dotnet/core-setup@637b9a7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The export from
declspec(dllexport)includes decoration for the__stdcallcalling convention. Explicitly export a non-decorated name for Windows x86.