Skip to content

Actually use correct versions in vs packages#11615

Merged
jkotalik merged 1 commit into
masterfrom
jkotalik/oops
Jun 27, 2019
Merged

Actually use correct versions in vs packages#11615
jkotalik merged 1 commit into
masterfrom
jkotalik/oops

Conversation

@jkotalik
Copy link
Copy Markdown
Contributor

Missed some dollar signs when passing in the version to the package name.

@jkotalik jkotalik requested a review from a team June 26, 2019 20:05
@Eilon Eilon added the feature-installers Includes: Installers label Jun 26, 2019
Copy link
Copy Markdown
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 😈

@dougbu
Copy link
Copy Markdown
Contributor

dougbu commented Jun 26, 2019

@dougbu
Copy link
Copy Markdown
Contributor

dougbu commented Jun 26, 2019

@jkotalik are you going to mark ResponseBodyWriteExceptions_ClientDisconnectsBeforeFirstWriteAsync_WriteThrows as flaky? If not I can retry the failing leg of the build.

@aspnet-hello
Copy link
Copy Markdown

This comment was made automatically. If there is a problem contact aspnetcore-build@microsoft.com.

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2314

@jkotalik
Copy link
Copy Markdown
Contributor Author

Chris already resolved the test failure here #11628

@jkotalik jkotalik merged commit 185d289 into master Jun 27, 2019
@ghost ghost deleted the jkotalik/oops branch June 27, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-installers Includes: Installers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants