Deal with blocking HttpSys tests#11628
Merged
Merged
Conversation
halter73
approved these changes
Jun 26, 2019
Contributor
|
WaitHandle!!! |
Contributor
|
While you at it, I just hit a flaky test with ResponseBodyWriteExceptions_ClientDisconnectsBeforeFirstWriteAsync_WriteThrows https://dev.azure.com/dnceng/public/_build/results?buildId=240388&view=ms.vss-test-web.build-test-results-tab. |
Member
Author
|
@jkotalik what about it? That's one of the tests I just changed. |
Contributor
|
I admit I didn't look at this PR at all. I just saw a failed HttpSys test on my PR and was like "AGHHHH CHRIS IT'S YOUR FAULT" and added a comment here. Glad it's resolved already. |
ghost
deleted the
amcasey
added
area-networking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/aspnet/AspNetCore-Internal/issues/2314
AzDo & Arcade have become exceptionally vulnerable to thread pool starvation. Each of these tests has a blocking call that may trigger a deadlock. I've converted them all to async.