Skip to content

Expose "InputElement" on qualified classes#29555

Merged
pranavkm merged 1 commit into
mainfrom
prkrishn/element-reference
Jan 25, 2021
Merged

Expose "InputElement" on qualified classes#29555
pranavkm merged 1 commit into
mainfrom
prkrishn/element-reference

Conversation

@pranavkm
Copy link
Copy Markdown
Contributor

@pranavkm pranavkm commented Jan 22, 2021

Fixes #24446

Updated copy of #24899

@pranavkm pranavkm requested a review from a team as a code owner January 22, 2021 22:21
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jan 22, 2021
@pranavkm pranavkm force-pushed the prkrishn/element-reference branch from 4836a1a to 8e83908 Compare January 22, 2021 22:23
@pranavkm pranavkm force-pushed the prkrishn/element-reference branch from 8e83908 to 3550fb2 Compare January 22, 2021 22:42
@pranavkm pranavkm added this to the 6.0-preview2 milestone Jan 22, 2021
@pranavkm pranavkm added community-contribution Indicates that the PR has been added by a community member api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews labels Jan 22, 2021
@ghost
Copy link
Copy Markdown

ghost commented Jan 22, 2021

Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:

  • The PR contains changes to the reference-assembly that describe the API change. Or, you have included a snippet of reference-assembly-style code that illustrates the API change.
  • The PR describes the impact to users, both positive (useful new APIs) and negative (breaking changes).
  • Someone is assigned to "champion" this change in the meeting, and they understand the impact and design of the change.

@pranavkm pranavkm added api-approved API was approved in API review, it can be implemented and removed api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews labels Jan 25, 2021
@pranavkm
Copy link
Copy Markdown
Contributor Author

@javiercn could I get a sign off on this?

Copy link
Copy Markdown
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But what about the perf!

@pranavkm
Copy link
Copy Markdown
Contributor Author

It'll get fixed eventually. But no, all those delegates make me cringe a bit. If we wanted to, we could turn them in to static lambdas (by letting the callback include the sending component). We have one benchmark that tracks this scenario, we can see if this makes a big difference in the rendering perf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-approved API was approved in API review, it can be implemented area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InputText component should provide a FocusAsync() method

4 participants