Add ElementReference to InputRadio#40828
Merged
Merged
Conversation
990f1f0 to
4d28bf0
Compare
MackinnonBuck
approved these changes
Mar 22, 2022
Member
MackinnonBuck
left a comment
There was a problem hiding this comment.
Looks great.
I believe the reason we didn't initially support this was because radio buttons were always being re-rendered, causing element references to frequently become invalidated, making them useless (#31610). However, since that was fixed in #40148, it should be safe to accept this change.
Thanks @campersau!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
Elementproperty toInputRadiojust like the input fields in #29555Since
InputRadioGroupdoes not use an actual DOM element I left it out.aspnetcore/src/Components/Web/src/Forms/InputRadioGroup.cs
Lines 53 to 63 in 82e6b60
Fixes #40804