[release/6.0] HTTP/3: Use new QuicStream.ReadsCompleted property in transport#35476
Closed
JamesNK wants to merge 1 commit intorelease/6.0from
Closed
[release/6.0] HTTP/3: Use new QuicStream.ReadsCompleted property in transport#35476JamesNK wants to merge 1 commit intorelease/6.0from
JamesNK wants to merge 1 commit intorelease/6.0from
Conversation
JamesNK
requested review from
BrennanConroy,
Tratcher and
halter73
as code owners
Tratcher
approved these changes
Aug 19, 2021
Member
Tratcher
left a comment
Tratcher
left a comment
There was a problem hiding this comment.
Does the Http/3 layer need any adjustments, or should that just work?
Member
Author
|
HTTP/3 layer will just work. It is already using the aspnetcore/src/Servers/Kestrel/Core/src/Internal/Http3/Http3Stream.cs Lines 428 to 434 in 6350af9 |
| @@ -240,12 +263,23 @@ private async Task DoReceive() | |||
| finally | |||
| { | |||
| // If Shutdown() has already bee called, assume that was the reason ProcessReceives() exited. | |||
Member
There was a problem hiding this comment.
not new code, but typo: "bee" -> "been"
adityamandaleeka
approved these changes
Aug 19, 2021
Member
Author
|
/backport to main |
Contributor
|
Started backporting to main: https://github.com/dotnet/aspnetcore/actions/runs/1145307320 |
Member
Author
|
/backport to release/6.0-rc1 |
Contributor
|
Started backporting to release/6.0-rc1: https://github.com/dotnet/aspnetcore/actions/runs/1145308311 |
This was referenced Aug 19, 2021
Member
Author
|
Closing this PR and have changes be merged from RC1 into back into 6.0 automatically. |
amcasey
added
area-networking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35399 Made this change in this branch first because main hasn't gotten latest runtime bits yet.