Modify HtmlRenderer to update content when a component re-renders#40512
Merged
Conversation
Contributor
Author
|
|
pranavkm
force-pushed
the
prkrishn/html-renderer
branch
from
15cf8fb to
c373aad
Compare
pranavkm
force-pushed
the
prkrishn/html-renderer
branch
from
c373aad to
b8d927b
Compare
Member
|
This is Very nice! Especially with the removal of I'd approve this PR, but it's still in draft. |
SteveSandersonMS
approved these changes
Mar 3, 2022
Member
SteveSandersonMS
left a comment
SteveSandersonMS
left a comment
There was a problem hiding this comment.
Approving even though it's draft
Member
|
Yeah, this is much nicer |
javiercn
approved these changes
Mar 3, 2022
ghost
added this to the
This was referenced Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change HtmlRenderer would return a snapshot of a component immediately after it was initially rendered. This meant any updates to a component as a result of other components rendering were lost.
In this change, we update the HtmlRenderer to return a placeholder
IHtmlContentthat retrieves render frames only whenWriteTois invoked. Typically MVC will defer calling WriteTo until the content is about to be sent to the wire, which means any updates to a component (e.g. HeadOutlet being updated) are picked up.Also updates the template to consolidate
_Hostand_Layout.Fixes #38400