Fix race in RST_STREAM_IncompleteRequest HTTP/2 tests#65454
Merged
adityamandaleeka merged 1 commit intodotnet:mainfrom Feb 18, 2026
Merged
Fix race in RST_STREAM_IncompleteRequest HTTP/2 tests#65454adityamandaleeka merged 1 commit intodotnet:mainfrom
adityamandaleeka merged 1 commit intodotnet:mainfrom
Conversation
Move tcs.TrySetResult() after WaitForConnectionErrorAsync to prevent the response HEADERS from racing with the GOAWAY frame. Same fix pattern as dotnet#57450 applied to AdditionalDataFrames and AdditionalTrailerFrames variants.
adityamandaleeka
requested review from
BrennanConroy,
JamesNK and
halter73
as code owners
github-actions
Bot
added
the
area-networking
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition in two HTTP/2 test methods where response headers could be written before the GOAWAY frame, causing test failures. The fix moves tcs.TrySetResult() to occur after WaitForConnectionErrorAsync, ensuring the response handler remains blocked until the connection error has been properly validated.
Changes:
- Move
tcs.TrySetResult()afterWaitForConnectionErrorAsyncinRST_STREAM_IncompleteRequest_AdditionalDataFrames_ConnectionAborted - Move
tcs.TrySetResult()afterWaitForConnectionErrorAsyncinRST_STREAM_IncompleteRequest_AdditionalTrailerFrames_ConnectionAborted - Add clarifying comments explaining the timing requirement
BrennanConroy
approved these changes
Feb 17, 2026
lewing
added a commit
that referenced
this pull request
Mar 9, 2026
Move tcs.TrySetResult() after StopConnectionAsync so the response handler stays blocked until the connection has stopped. This prevents response HEADERS from being written before the GOAWAY frame, which caused the test to intermittently fail with 'Expected: GOAWAY, Actual: HEADERS'. This is the same fix pattern applied in #65454 for the sibling AdditionalDataFrames and AdditionalTrailerFrames tests, and in #57450 for the AdditionalWindowUpdateFrame test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
11 tasks
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
Move tcs.TrySetResult() after StopConnectionAsync so the response handler stays blocked until the connection has stopped. This prevents response HEADERS from being written before the GOAWAY frame, which caused the test to intermittently fail with 'Expected: GOAWAY, Actual: HEADERS'. This is the same fix pattern applied in #65454 for the sibling AdditionalDataFrames and AdditionalTrailerFrames tests, and in #57450 for the AdditionalWindowUpdateFrame test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lewing
added a commit
that referenced
this pull request
Mar 10, 2026
…65715) * Fix race in RST_STREAM_IncompleteRequest_AdditionalResetFrame test Move tcs.TrySetResult() after StopConnectionAsync so the response handler stays blocked until the connection has stopped. This prevents response HEADERS from being written before the GOAWAY frame, which caused the test to intermittently fail with 'Expected: GOAWAY, Actual: HEADERS'. This is the same fix pattern applied in #65454 for the sibling AdditionalDataFrames and AdditionalTrailerFrames tests, and in #57450 for the AdditionalWindowUpdateFrame test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix RST_STREAM additional reset test ordering Wait for the request to be aborted before releasing the application delegate gate in RST_STREAM_IncompleteRequest_AdditionalResetFrame_IgnoreAdditionalReset. This preserves the test intent while avoiding both the HEADERS-vs-GOAWAY race and the shutdown timeout.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wtgodbe
pushed a commit
that referenced
this pull request
Mar 10, 2026
…etFrame test (#65718) * Fix race in RST_STREAM_IncompleteRequest_AdditionalResetFrame test Move tcs.TrySetResult() after StopConnectionAsync so the response handler stays blocked until the connection has stopped. This prevents response HEADERS from being written before the GOAWAY frame, which caused the test to intermittently fail with 'Expected: GOAWAY, Actual: HEADERS'. This is the same fix pattern applied in #65454 for the sibling AdditionalDataFrames and AdditionalTrailerFrames tests, and in #57450 for the AdditionalWindowUpdateFrame test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix RST_STREAM additional reset test ordering Wait for the request to be aborted before releasing the application delegate gate in RST_STREAM_IncompleteRequest_AdditionalResetFrame_IgnoreAdditionalReset. This preserves the test intent while avoiding both the HEADERS-vs-GOAWAY race and the shutdown timeout.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Larry Ewing <lewing@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lewing
added a commit
that referenced
this pull request
Mar 16, 2026
…ersion pinning (#65781) * Fix race in RST_STREAM_IncompleteRequest_AdditionalResetFrame test Move tcs.TrySetResult() after StopConnectionAsync so the response handler stays blocked until the connection has stopped. This prevents response HEADERS from being written before the GOAWAY frame, which caused the test to intermittently fail with 'Expected: GOAWAY, Actual: HEADERS'. This is the same fix pattern applied in #65454 for the sibling AdditionalDataFrames and AdditionalTrailerFrames tests, and in #57450 for the AdditionalWindowUpdateFrame test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix RST_STREAM additional reset test ordering Wait for the request to be aborted before releasing the application delegate gate in RST_STREAM_IncompleteRequest_AdditionalResetFrame_IgnoreAdditionalReset. This preserves the test intent while avoiding both the HEADERS-vs-GOAWAY race and the shutdown timeout.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix Blazor WASM template tests NU1603 with DevServer version pinning Pin the DevServer package to the exact locally-built version in the template test infrastructure so that stable versions from darc feeds (which outrank prerelease versions in SemVer) don't cause NU1603. With TreatWarningsAsErrors enabled, NU1603 becomes fatal, breaking BlazorWasmStandaloneTemplate_Works and related tests whenever a VMR official build publishes a stable DevServer to a darc feed. The fix pipes MicrosoftAspNetCoreComponentsWebAssemblyDevServerVersion through PrepareForTest.targets into Directory.Build.props.in, which adds a PackageReference Update with an exact version range [x.y.z-ci]. This ensures the locally-built package is always used during tests. The shipped template continues using >= semantics for customers. Fixes #65701 * Move PackageReference Update to .targets.in (imported after project) PackageReference Update in Directory.Build.props runs before the project file, so it cannot affect items declared in the project. Move to Directory.Build.targets.in which is imported after, and pipe the version variable to the targets template instead. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix race condition in
RST_STREAM_IncompleteRequest_AdditionalDataFrames_ConnectionAbortedandRST_STREAM_IncompleteRequest_AdditionalTrailerFrames_ConnectionAbortedtests.Problem
tcs.TrySetResult()was called beforeWaitForConnectionErrorAsync, allowing the request handler to complete and write response HEADERS into the output pipe before the GOAWAY frame. SinceignoreNonGoAwayFrames: false, the test fails when it reads HEADERS instead of GOAWAY.Fix
Move
tcs.TrySetResult()afterWaitForConnectionErrorAsyncso the response handler stays blocked until the GOAWAY has been sent and verified. This is the same fix pattern applied in #57450 for the analogousAdditionalWindowUpdateFrametest.