[release/10.0] Fix race in RST_STREAM_IncompleteRequest HTTP/2 tests#65717
Merged
wtgodbe merged 1 commit intorelease/10.0from Mar 10, 2026
Merged
[release/10.0] Fix race in RST_STREAM_IncompleteRequest HTTP/2 tests#65717wtgodbe merged 1 commit intorelease/10.0from
wtgodbe merged 1 commit intorelease/10.0from
Conversation
Move tcs.TrySetResult() after WaitForConnectionErrorAsync to prevent the response HEADERS from racing with the GOAWAY frame. Same fix pattern as #57450 applied to AdditionalDataFrames and AdditionalTrailerFrames variants.
github-actions
Bot
requested review from
BrennanConroy,
JamesNK and
halter73
as code owners
github-actions
Bot
added
the
area-networking
Member
|
test only change no need for servicing approval |
lewing
approved these changes
Mar 9, 2026
wtgodbe
added
tell-mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #65454 to release/10.0
/cc @lewing @adityamandaleeka
Fix race in RST_STREAM_IncompleteRequest HTTP/2 tests
Summary of the changes (Less than 80 chars)
Description
{Detail}
Fixes #{bug number} (in this specific format)
Customer Impact
{Justification}
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
When servicing release/2.3