[test-quarantine] Quarantine ServerVirtualizationTest.DynamicContent_PrependItemsWhileScrolledToMiddle_VisibleItemsStayInPlace#66312
Merged
ilonatommy merged 2 commits intomainfrom Apr 14, 2026
Conversation
…crolledToMiddle_VisibleItemsStayInPlace Test has failed 4 times in pipeline 87. Server-only flakiness (base VirtualizationTest passes). Add virtual modifier to base class and quarantine override in ServerVirtualizationTest. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
needs-area-label
ilonatommy
added
area-blazor
ilonatommy
approved these changes
Apr 14, 2026
ilonatommy
deleted the
quarantine/server-virtualization-dynamic-content-prepend-140c6fc65d0f3538
branch
ilonatommy
added a commit
to ilonatommy/aspnetcore
that referenced
this pull request
Apr 14, 2026
…e, restore missing PrependItems quarantine The merge from main incorrectly re-introduced a quarantine for CanElevateEffectiveMaxItemCount_WhenOverscanExceedsMax (dotnet#65962) which was already fixed and unquarantined by dotnet#66291 on main. It also dropped the DynamicContent_PrependItemsWhileScrolledToMiddle quarantine (dotnet#66308) that was added by dotnet#66312 on main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ilonatommy
added a commit
that referenced
this pull request
Apr 17, 2026
…re test setup (#66290) * Stabilize NonZeroStartIndex_ScrollToMiddleThenMeasure E2E test setup Apply the same retry-based scroll stabilization pattern from PR #66194 to NonZeroStartIndex_ScrollToMiddleThenMeasure. The test was racing in server mode because it set scrollTop and then immediately checked the rendered items, but the async virtualization update had not finished yet. The fix computes the target offset up front, then retries both the scroll assignment and the rendered-index check inside a single Browser.True() loop before calling WaitForScrollStabilization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Apply review feedback: fix spacing and reuse ScrollToOffsetWithStabilization helper - Fix missing space around = in targetScrollTop assignment - Extract scroll+retry logic into generalized ScrollToOffsetWithStabilization overload - Reuse the helper in NonZeroStartIndex_ScrollToMiddleThenMeasure instead of duplicating Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix bad merge: remove stale CanElevateEffectiveMaxItemCount quarantine, restore missing PrependItems quarantine The merge from main incorrectly re-introduced a quarantine for CanElevateEffectiveMaxItemCount_WhenOverscanExceedsMax (#65962) which was already fixed and unquarantined by #66291 on main. It also dropped the DynamicContent_PrependItemsWhileScrolledToMiddle quarantine (#66308) that was added by #66312 on main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use MutationObserver instead of scroll retry loop in NonZeroStartIndex test Replace the retry-based ScrollToOffsetWithStabilization call with a single scrollTop assignment followed by a MutationObserver that waits for Blazor's DOM update to settle. This makes the test more deterministic: it scrolls once and waits for the effect, rather than retrying the scroll which could mask real bugs where the component fails to handle the initial scroll correctly. The MutationObserver waits for a 200ms quiet period after the last DOM mutation, with a 2s fallback timeout. After that, scroll position stabilization is verified, and the item index assertion is a hard assert (not a retry loop). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quarantines
ServerVirtualizationTest.DynamicContent_PrependItemsWhileScrolledToMiddle_VisibleItemsStayInPlacewhich is flaky in server-execution mode.Changes
DynamicContent_PrependItemsWhileScrolledToMiddle_VisibleItemsStayInPlacevirtualinVirtualizationTest.cs(base class — WASM/static variant passes fine and is unaffected)ServerVirtualizationTestinTestSubclasses.csfollowing the same pattern as other quarantined server-only test overridesFailure summary
components-e2epipeline (definition 87)Assert.True() Failure— timing race in server-side Blazor when prepending itemsTracking issue: https://github.com/dotnet/aspnetcore/issues/#66308
Note
🔒 Integrity filter blocked 22 items
The following items were blocked because they don't meet the GitHub integrity level.
search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: