Skip to content

Fix TerminalLogger hiding Exec output#66135

Open
minaxi98 wants to merge 4 commits intodotnet:mainfrom
minaxi98:improve/terminal-logger-visibility/62273
Open

Fix TerminalLogger hiding Exec output#66135
minaxi98 wants to merge 4 commits intodotnet:mainfrom
minaxi98:improve/terminal-logger-visibility/62273

Conversation

@minaxi98
Copy link
Copy Markdown

@minaxi98 minaxi98 commented Apr 4, 2026

Set StandardOutputImportance="high" so dotnet-getdocument output is visible. Fixes #62273

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Root cause: The Exec task in Microsoft.Extensions.ApiDescription.Server.targets:67 logged stdout at default Normal importance. The .NET 8 TerminalLogger suppresses Normal-importance messages.

Fix: Added StandardOutputImportance="high" to the Exec task so the dotnet-getdocument.dll output (e.g., Generating document named 'v1') is elevated to high importance, which the TerminalLogger surfaces by default.

README update: Added a section documenting Terminal Logger behavior and the -tlp:v=d flag for more verbose output.

Fixes #62273

Set StandardOutputImportance="high" so dotnet-getdocument output is visible. Update README with TerminalLogger details.

Fixes dotnet#62273
@github-actions github-actions Bot added the area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI label Apr 4, 2026
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Apr 4, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Thanks for your PR, @minaxi98. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@minaxi98
Copy link
Copy Markdown
Author

minaxi98 commented Apr 4, 2026

@dotnet-policy-service agree

This was referenced Apr 4, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

…C# 14 extension type methods

Separate the DB query from the in-memory projection in both UserStore and UserOnlyStore
so ToUserPasskeyInfo() is never placed inside a LINQ expression tree. This prevents
intermittent process crashes on preview toolchains where EF Core's client-side evaluation
of C# 14 extension type method calls can fail.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft.Extensions.ApiDescription.Server - Surface Invocation with new TerminalLogger

1 participant