[test-quarantine] Quarantine RendererTest.DisposingRenderer_UnsubsribesFromHotReloadManager and HotReload_ReRenderPreservesAsyncLocalValues#66154
Closed
github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
DisposingRenderer_UnsubsribesFromHotReloadManager and HotReload_ReRenderPreservesAsyncLocalValues have each failed 3 times in the last 30 days (build 1359484). The failures suggest timing issues with HotReloadManager subscription state and AsyncLocal value propagation across threads during hot reload callbacks. Associated issue: #aw_renderer Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
The source build here is https://dev.azure.com/dnceng-public/public/_build/results?buildId=1359484&view=results, which is against an open PR. Closing & figuring out how to fix up the workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quarantines two flaky Blazor RendererTest methods that have each failed 3 times in the last 30 days (build 1359484, pipeline 83).
Tests
Microsoft.AspNetCore.Components.Test.RendererTest.DisposingRenderer_UnsubsribesFromHotReloadManagerAssert.True() Failure—IsSubscribedToreturns false beforeDisposewas calledMicrosoft.AspNetCore.Components.Test.RendererTest.HotReload_ReRenderPreservesAsyncLocalValuesAssert.Equal() Failure: Expected: "AmbientValue", Actual: nullBoth tests involve the
HotReloadManagersubscription lifecycle and appear to have timing-related failures:Disposeis even called, suggesting the subscription is not established promptlyAsyncLocalvalue is not propagated to the fresh thread spawned by the hot reload callbackAssociated issue: #66146
Note
🔒 Integrity filter blocked 12 items
The following items were blocked because they don't meet the GitHub integrity level.
search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".issue_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".issue_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: