This repository was archived by the owner on Jan 11, 2024. It is now read-only.
Replace Xunit.PlatformID with Xunit.TestPlatforms#1000
Merged
Conversation
`Xunit.PlatformID` conflicts with `System.PlatformID` and should be plural according to the naming guidelines for flags enums. This commit adds a new `Xunit.TestPlatforms` enum as a replacement for `Xunit.PlatformID`. `Xunit.PlatformID` remains for now, until all uses have transitioned to the new enum.
|
Hi @justinvp, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
Author
| (platforms.HasFlag(PlatformID.NetBSD) && RuntimeInformation.IsOSPlatform(OSPlatform.Create("NETBSD"))) || | ||
| (platforms.HasFlag(PlatformID.OSX) && RuntimeInformation.IsOSPlatform(OSPlatform.OSX)) || | ||
| (platforms.HasFlag(PlatformID.Windows) && RuntimeInformation.IsOSPlatform(OSPlatform.Windows))) | ||
| TestPlatforms platforms = (TestPlatforms)ctorArgs.Last(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
|
LGTM |
justinvp
referenced
this pull request
in dotnet/corefx
Sep 14, 2016
weshaggard
added a commit
to weshaggard/corefx
that referenced
this pull request
Oct 1, 2016
This allows us to start using TestPlatforms added with dotnet/buildtools#1000
weshaggard
added a commit
to weshaggard/corefx
that referenced
this pull request
Oct 1, 2016
This allows us to start using TestPlatforms added with dotnet/buildtools#1000
macrogreg
pushed a commit
to open-telemetry/opentelemetry-dotnet-instrumentation
that referenced
this pull request
Sep 24, 2020
This allows us to start using TestPlatforms added with dotnet/buildtools#1000 Commit migrated from dotnet/corefx@64a737e
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This allows us to start using TestPlatforms added with dotnet/buildtools#1000 Commit migrated from dotnet/corefx@64a737e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xunit.PlatformIDconflicts withSystem.PlatformIDand should be plural according to the naming guidelines for flags enums.This commit adds a new
Xunit.TestPlatformsenum as a replacement forXunit.PlatformID.Xunit.PlatformIDremains for now, until all uses have transitioned to the new enum.Part of: #999