This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Replace uses of Xunit.PlatformID with renamed TestPlatforms#12284
Merged
Conversation
Replace uses of `Xunit.PlatformID` with renamed `TestPlatforms` because the old name conflicts with `System.PlatformID` and should be plural according to the design guidelines for flags enums.
justinvp
force-pushed
the
testplatforms
branch
from
1d5384f to
5179dda
Compare
Contributor
Author
|
Thanks, @stephentoub! cc: @weshaggard as FYI |
This was referenced Oct 2, 2016
Merged
Member
|
Thanks @justinvp |
This was referenced Oct 3, 2016
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Replace uses of Xunit.PlatformID with renamed TestPlatforms Commit migrated from dotnet/corefx@3d3c860
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace uses of
Xunit.PlatformIDwith renamedTestPlatformsbecause the old name conflicts withSystem.PlatformIDand should be plural according to the design guidelines for flags enums.Reference:
#12267
dotnet/buildtools#999
dotnet/buildtools#1000