Adding TLS Alerts by CIPop · Pull Request #11489 · dotnet/corefx

CIPop · 2016-09-07T00:57:28Z

Adding TLS handshake and close_notify SslStream alert support.
New API needs review and is pending the investigation in #11265.

Fixes #8811
Addresses part of #3114.

@davidsh @bartonjs @stephentoub PTAL
/cc @weshaggard

davidsh · 2016-09-07T01:03:46Z

@dshulman @bartonjs @stephentoub PTAL

@CIPop My GitHub handle is @davidsh and not @dshulman

CIPop · 2016-09-07T17:39:59Z

@davidsh Thanks for catching that! Corrected above.

bartonjs · 2016-09-07T18:09:12Z

+                {
+                    contextHandle = refContext._handle;
+                }
+                try


Nit: Please put a blank line here; I automatically read this as an "else" to the if.

+1 (missed as the file was only renamed, probably with minimal changes)

Ah, actually this is new code. Will correct.

justinvp · 2016-10-02T16:32:38Z

+        }
+
+        [Fact]
+        [PlatformSpecific(PlatformID.Windows)]


PlatformID has been renamed TestPlatforms. It would be good if it was updated here before merging. See #12284.

justinvp · 2016-10-02T16:32:46Z

+        }
+
+        [Fact]
+        [PlatformSpecific(PlatformID.Windows)]


PlatformID has been renamed TestPlatforms. It would be good if it was updated here before merging. See #12284.

justinvp · 2016-10-02T16:32:58Z

+        }
+
+        [Fact]
+        [PlatformSpecific(PlatformID.Windows)]


PlatformID has been renamed TestPlatforms. It would be good if it was updated here before merging. See #12284.

Will do. Thanks @justinvp .

davidsh · 2016-10-04T22:46:36Z

Test OuterLoop CentOS7.1 Debug Build and Test
Test OuterLoop OSX Debug Build and Test
Test OuterLoop Ubuntu14.04 Debug Build and Test
Test OuterLoop Windows_NT Debug Build and Test

davidsh

LGTM.

weshaggard · 2016-10-06T21:26:04Z

        public override int Read(byte[] buffer, int offset, int count) { return default(int); }
        public override long Seek(long offset, System.IO.SeekOrigin origin) { return default(long); }
        public override void SetLength(long value) { }
+        public virtual System.Threading.Tasks.Task ShutdownAsync() { return default(System.Threading.Tasks.Task); }


This API needs to be added as .NET Core specific instead of as being part of netstandard. See #12311 as an example.

weshaggard · 2016-10-06T21:28:44Z

@@ -31,29 +31,34 @@
  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'net46_Release|AnyCPU'" />


slightly orthogonal: The NugetTargetMoniker looks a strange here. It is netstandard1.3 for everything but unix where it is netstandard16. @ericstj are there any issues with this approach?

I'm confused by this as well. This probably needs to be updated to netstandard1.7 anyway? (I see #11265 doing some of those changes.)

Petermarcu · 2016-10-13T22:01:28Z

@CIPop , Is all thats left here to get it moved into netcoreapp1.2?

CIPop · 2016-10-13T22:24:22Z

@Petermarcu Yes, I believe most of the build issues are because of this contract having the wrong TFM.

I need to read through the docs and figure out what needs to change to fix the following errors:

ClientAsyncAuthenticateTest.cs(135,13): error CS0246: The type or namespace name 'EncryptionPolicy' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
SslStreamStreamToStreamTest.cs(21,45): error CS0246: The type or namespace name 'SslStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
SslStreamStreamToStreamTest.cs(21,72): error CS0246: The type or namespace name 'SslStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
SslStreamStreamToStreamTest.cs(233,45): error CS0246: The type or namespace name 'SslStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
SslStreamStreamToStreamTest.cs(233,72): error CS0246: The type or namespace name 'SslStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
SslStreamStreamToStreamTest.cs(246,45): error CS0246: The type or namespace name 'SslStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
SslStreamStreamToStreamTest.cs(246,72): error CS0246: The type or namespace name 'SslStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
SslStreamStreamToStreamTest.cs(265,45): error CS0246: The type or namespace name 'SslStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
SslStreamStreamToStreamTest.cs(265,72): error CS0246: The type or namespace name 'SslStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
NegotiateStreamStreamToStreamTest.cs(20,59): error CS0246: The type or namespace name 'NegotiateStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
NegotiateStreamStreamToStreamTest.cs(21,59): error CS0246: The type or namespace name 'NegotiateStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
NegotiateStreamStreamToStreamTest.cs(267,59): error CS0246: The type or namespace name 'NegotiateStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
NegotiateStreamStreamToStreamTest.cs(270,59): error CS0246: The type or namespace name 'NegotiateStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
NegotiateStreamStreamToStreamTest.cs(276,59): error CS0246: The type or namespace name 'NegotiateStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
NegotiateStreamStreamToStreamTest.cs(279,59): error CS0246: The type or namespace name 'NegotiateStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
NegotiateStreamStreamToStreamTest.cs(285,59): error CS0246: The type or namespace name 'NegotiateStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
NegotiateStreamStreamToStreamTest.cs(288,59): error CS0246: The type or namespace name 'NegotiateStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
S:\c1\src\Common\tests\System\Net\SchSendAuxRecordTestServer.cs(111,51): error CS0246: The type or namespace name 'SslStream' could not be found (are you missing a using directive or an assembly reference?) [S:\c1\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
S:\c1\Tools\Packaging.targets(602,5): error : File S:\c1\bin\Windows_NT.AnyCPU.Debug\System.Net.Security\net46\System.Net.Security.dll does not exist, ensure you have built libraries before building the package. [S:\c1\src\System.Net.Security\pkg\System.Net.Security.pkgproj]
S:\c1\Tools\Packaging.targets(602,5): error : File S:\c1\bin\Windows_NT.AnyCPU.Debug\System.Net.Security\net46\System.Net.Security.dll does not exist, ensure you have built libraries before building the package. [S:\c1\src\System.Net.Security\pkg\System.Net.Security.pkgproj]
S:\c1\Tools\Packaging.targets(602,5): error : File S:\c1\bin\Windows_NT.AnyCPU.Debug\System.Net.Security\net46\System.Net.Security.dll does not exist, ensure you have built libraries before building the package. [S:\c1\src\System.Net.Security\pkg\System.Net.Security.pkgproj]
S:\c1\Tools\Packaging.targets(1148,5): error : Error when creating nuget lib package from S:\c1\bin\packages\Debug\specs\System.Net.Security.nuspec. System.IO.FileNotFoundException: File not found: 'S:\c1\bin\Windows_NT.AnyCPU.Debug\System.Net.Security\net46\System.Net.Security.dll'. [S:\c1\src\System.Net.Security\pkg\System.Net.Security.pkgproj]
S:\c1\Tools\Packaging.targets(1148,5): error :    at NuGet.Packaging.PackageBuilder.AddFiles(String basePath, String source, String destination, String exclude) [S:\c1\src\System.Net.Security\pkg\System.Net.Security.pkgproj]
S:\c1\Tools\Packaging.targets(1148,5): error :    at NuGet.Packaging.PackageBuilder.PopulateFiles(String basePath, IEnumerable`1 files) [S:\c1\src\System.Net.Security\pkg\System.Net.Security.pkgproj]
S:\c1\Tools\Packaging.targets(1148,5): error :    at Microsoft.DotNet.Build.Tasks.Packaging.NuGetPack.Pack(String nuspecPath, Func`2 nuspecPropertyProvider, Boolean packSymbols) [S:\c1\src\System.Net.Security\pkg\System.Net.Security.pkgproj]
S:\c1\Tools\Packaging.targets(1148,5): error : Error when creating nuget symbol package from S:\c1\bin\packages\Debug\specs\System.Net.Security.nuspec. System.IO.FileNotFoundException: File not found: 'S:\c1\bin\Windows_NT.AnyCPU.Debug\System.Net.Security\net46\System.Net.Security.dll'. [S:\c1\src\System.Net.Security\pkg\System.Net.Security.pkgproj]
S:\c1\Tools\Packaging.targets(1148,5): error :    at NuGet.Packaging.PackageBuilder.AddFiles(String basePath, String source, String destination, String exclude) [S:\c1\src\System.Net.Security\pkg\System.Net.Security.pkgproj]
S:\c1\Tools\Packaging.targets(1148,5): error :    at NuGet.Packaging.PackageBuilder.PopulateFiles(String basePath, IEnumerable`1 files) [S:\c1\src\System.Net.Security\pkg\System.Net.Security.pkgproj]
S:\c1\Tools\Packaging.targets(1148,5): error :    at Microsoft.DotNet.Build.Tasks.Packaging.NuGetPack.Pack(String nuspecPath, Func`2 nuspecPropertyProvider, Boolean packSymbols) [S:\c1\src\System.Net.Security\pkg\System.Net.Security.pkgproj]

…encies and tests.

After dotnet#11489 This error shows up after trying to consume the new packages. SslStreamAlertsTest.cs(81,30): error CS1061: 'SslStream' does not contain a definition for 'ShutdownAsync' and no extension method 'ShutdownAsync' accepting a first argument of type 'SslStream' could be found (are you missing a using directive or an assembly reference?) [D:\A\_work\55\s\corefx\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj] For now disabling these tests by conditioning them on netcoreapp1.1.

Adding TLS Alerts Commit migrated from dotnet/corefx@d9c476a

After dotnet/corefx#11489 This error shows up after trying to consume the new packages. SslStreamAlertsTest.cs(81,30): error CS1061: 'SslStream' does not contain a definition for 'ShutdownAsync' and no extension method 'ShutdownAsync' accepting a first argument of type 'SslStream' could be found (are you missing a using directive or an assembly reference?) [D:\A\_work\55\s\corefx\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj] For now disabling these tests by conditioning them on netcoreapp1.1. Commit migrated from dotnet/corefx@4f9f736

CIPop added area-System.Net 3 - Ready For Review labels Sep 7, 2016

CIPop added this to the 1.1.0 milestone Sep 7, 2016

CIPop self-assigned this Sep 7, 2016

dnfclas added the cla-already-signed label Sep 7, 2016

bartonjs reviewed Sep 7, 2016
View reviewed changes

karelz removed the 3 - Ready For Review label Sep 13, 2016

karelz removed this from the 1.1.0 milestone Sep 22, 2016

CIPop force-pushed the ssl branch from 51a2c6d to 046ae8f Compare September 27, 2016 22:30

justinvp reviewed Oct 2, 2016

View reviewed changes

justinvp mentioned this pull request Oct 2, 2016

Remove Xunit.PlatformID enum dotnet/buildtools#1084

Merged

CIPop force-pushed the ssl branch 2 times, most recently from 911a41b to b3042ef Compare October 4, 2016 00:53

davidsh approved these changes Oct 4, 2016

View reviewed changes

CIPop force-pushed the ssl branch 2 times, most recently from 2c77d5d to 49b9eb8 Compare October 6, 2016 21:21

weshaggard reviewed Oct 6, 2016

View reviewed changes

CIPop mentioned this pull request Oct 6, 2016

Add System.SystemException derivations #12351

Merged

CIPop mentioned this pull request Oct 6, 2016

WIP: Adding new SslStream API #11265

Closed

CIPop force-pushed the ssl branch from 49b9eb8 to aed45af Compare October 12, 2016 22:04

Adding close_notify and TLS handshake alert support for SslStream.

32e0e3a

CIPop force-pushed the ssl branch from aed45af to 32e0e3a Compare October 14, 2016 20:23

Switching Security to netstandard1.7/net463. Updating contract depend…

991edf9

…encies and tests.

CIPop force-pushed the ssl branch from e14f15d to 991edf9 Compare October 15, 2016 00:20

CIPop merged commit d9c476a into dotnet:master Oct 15, 2016

weshaggard mentioned this pull request Oct 17, 2016

Disable SslStreamAlertTests by making them netcoreapp1.1 specific #12733

Merged

CIPop deleted the ssl branch October 17, 2016 23:15

karelz modified the milestone: 1.2.0 Dec 3, 2016

This was referenced Jan 31, 2020

Tracking items for System.Net.Security dotnet/runtime#15141

Closed

System.Net.SslStream new APIs for TLS Alert support dotnet/runtime#18785

Closed

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022

Merge pull request dotnet/corefx#11489 from CIPop/ssl

d0b499d

Adding TLS Alerts Commit migrated from dotnet/corefx@d9c476a

		@@ -31,29 +31,34 @@
		<PropertyGroup Condition="'$(Configuration)\|$(Platform)' == 'net46_Release\|AnyCPU'" />

Conversation

CIPop commented Sep 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidsh commented Sep 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CIPop commented Sep 7, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CIPop Sep 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidsh commented Oct 4, 2016

Uh oh!

davidsh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Petermarcu commented Oct 13, 2016

Uh oh!

CIPop commented Oct 13, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

CIPop commented Sep 7, 2016 •

edited

Loading

davidsh commented Sep 7, 2016 •

edited

Loading

CIPop Sep 7, 2016 •

edited

Loading