This repository was archived by the owner on Jan 11, 2024. It is now read-only.
Remove Xunit.PlatformID enum#1084
Merged
Merged
Conversation
It has been replaced by Xunit.TestPlatforms
|
Hi @justinvp, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
Author
|
cc: @weshaggard |
Member
|
@justinvp there are other repo's that are using this right now as well. At least the WCF repo is so I would prefer we give this remove a little more time. |
Member
|
Sorry I didn't read you full description. Thanks for looking into other usages and if WCF isn't using this then I'm good with going ahead and removing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that dotnet/corefx#12284 has been merged, we can delete
PlatformID(replaced byTestPlatforms).I did a search on GitHub and while there are some repos besides corefx using
Microsoft.xunit.netcore.extensions(e.g. wcf, corefxlab), none that I could find are usingPlatformID. (There may be private repos that need to be updated at some point that I can't see).The following open corefx PRs are still using
PlatformIDin some way. I've left comments in each about the rename:Fixes #999