Skip to content
This repository was archived by the owner on Jan 11, 2024. It is now read-only.

Remove Xunit.PlatformID enum#1084

Merged
weshaggard merged 1 commit into
dotnet:masterfrom
justinvp:platformid
Oct 3, 2016
Merged

Remove Xunit.PlatformID enum#1084
weshaggard merged 1 commit into
dotnet:masterfrom
justinvp:platformid

Conversation

@justinvp
Copy link
Copy Markdown

@justinvp justinvp commented Oct 2, 2016

Now that dotnet/corefx#12284 has been merged, we can delete PlatformID (replaced by TestPlatforms).

I did a search on GitHub and while there are some repos besides corefx using Microsoft.xunit.netcore.extensions (e.g. wcf, corefxlab), none that I could find are using PlatformID. (There may be private repos that need to be updated at some point that I can't see).

The following open corefx PRs are still using PlatformID in some way. I've left comments in each about the rename:

Fixes #999

It has been replaced by Xunit.TestPlatforms
@dnfclas
Copy link
Copy Markdown

dnfclas commented Oct 2, 2016

Hi @justinvp, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@justinvp
Copy link
Copy Markdown
Author

justinvp commented Oct 2, 2016

cc: @weshaggard

@weshaggard
Copy link
Copy Markdown
Member

@justinvp there are other repo's that are using this right now as well. At least the WCF repo is so I would prefer we give this remove a little more time.

@weshaggard
Copy link
Copy Markdown
Member

Sorry I didn't read you full description. Thanks for looking into other usages and if WCF isn't using this then I'm good with going ahead and removing it.

@weshaggard weshaggard merged commit eb366f0 into dotnet:master Oct 3, 2016
@justinvp justinvp deleted the platformid branch October 3, 2016 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants