This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Disable SslStreamAlertTests by making them netcoreapp1.1 specific#12733
Merged
Conversation
After dotnet#11489 This error shows up after trying to consume the new packages. SslStreamAlertsTest.cs(81,30): error CS1061: 'SslStream' does not contain a definition for 'ShutdownAsync' and no extension method 'ShutdownAsync' accepting a first argument of type 'SslStream' could be found (are you missing a using directive or an assembly reference?) [D:\A\_work\55\s\corefx\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj] For now disabling these tests by conditioning them on netcoreapp1.1.
stephentoub
approved these changes
Oct 17, 2016
joperezr
approved these changes
Oct 17, 2016
Member
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
LGTM. Can we also log an issue for this to get tracked?
Member
Author
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…ertsTests Disable SslStreamAlertTests by making them netcoreapp1.1 specific Commit migrated from dotnet/corefx@bb24814
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #11489
This error shows up after trying to consume the new packages.
SslStreamAlertsTest.cs(81,30): error CS1061: 'SslStream' does not contain a definition for 'ShutdownAsync' and no extension method 'ShutdownAsync' accepting a first argument of type 'SslStream' could be found (are you missing a using directive or an assembly reference?) [D:\A_work\55\s\corefx\src\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj]
For now disabling these tests by conditioning them on netcoreapp1.1.
@CIPop you will need to fix the issue with your PR to create a netcoreapp1.1 build configuration for the ref and these tests in order to re-enable them.
FYI @sepidehms @joperezr