This repository was archived by the owner on Apr 20, 2023. It is now read-only.
fix typo in RuntimeFrameworkVersion under FrameworkReference#12971
Closed
zsd4yr wants to merge 1 commit intodotnet:masterfrom
Closed
fix typo in RuntimeFrameworkVersion under FrameworkReference#12971zsd4yr wants to merge 1 commit intodotnet:masterfrom
zsd4yr wants to merge 1 commit intodotnet:masterfrom
Conversation
Author
|
This also appears to be the case on some release branches. including Release/3.0.1xx Line 14 in 973a51d Not sure what if any bugs resulted from this typo so I cannot advise on the scope this change should have |
Contributor
|
Ugh. Thanks |
Contributor
|
The typo is from 19 days ago, after 3.0 shipped. Thankfully. The master branch is closed and has merged into toolset. I'll port this to 3.0/3.1 |
Author
|
Thanks @nguerrera --sorry it's hard to keep track of where to make changes nowadays! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MicrosoftNETCoreAppRuntimePackageVersionis used byRuntimeFrameworkVersionunderFrameworkReferenceinDirectory.Build.targetsas well asglobal.json's tools.runtimes.dotnet. It is defined in Versions.props belowcli/eng/Versions.props
Lines 21 to 22 in edb2400
However, it was incorrectly typed in
RuntimeFrameworkVersionunderFrameworkReferenceinDirectory.Build.targets. This PR fixes that typo