Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

fix typo in RuntimeFrameworkVersion under FrameworkReference#12971

Closed
zsd4yr wants to merge 1 commit intodotnet:masterfrom
zsd4yr:dev/zadanz/directoryBuildTargets-typo
Closed

fix typo in RuntimeFrameworkVersion under FrameworkReference#12971
zsd4yr wants to merge 1 commit intodotnet:masterfrom
zsd4yr:dev/zadanz/directoryBuildTargets-typo

Conversation

@zsd4yr
Copy link

@zsd4yr zsd4yr commented Oct 23, 2019

MicrosoftNETCoreAppRuntimePackageVersion is used by RuntimeFrameworkVersion under FrameworkReference in Directory.Build.targets as well as global.json's tools.runtimes.dotnet. It is defined in Versions.props below

cli/eng/Versions.props

Lines 21 to 22 in edb2400

<MicrosoftNETCoreAppRuntimewinx64PackageVersion>5.0.0-alpha1.19520.3</MicrosoftNETCoreAppRuntimewinx64PackageVersion>
<MicrosoftNETCoreAppRuntimePackageVersion>$(MicrosoftNETCoreAppRuntimewinx64PackageVersion)</MicrosoftNETCoreAppRuntimePackageVersion>

However, it was incorrectly typed in RuntimeFrameworkVersion under FrameworkReference in Directory.Build.targets. This PR fixes that typo

@zsd4yr
Copy link
Author

zsd4yr commented Oct 23, 2019

This also appears to be the case on some release branches. including Release/3.0.1xx

RuntimeFrameworkVersion="$(MicrosoftNETCoreAppRuntimePackageersion)" />

Not sure what if any bugs resulted from this typo so I cannot advise on the scope this change should have

@nguerrera
Copy link
Contributor

Ugh. Thanks

@nguerrera
Copy link
Contributor

The typo is from 19 days ago, after 3.0 shipped. Thankfully. The master branch is closed and has merged into toolset. I'll port this to 3.0/3.1

@nguerrera nguerrera closed this Oct 23, 2019
@zsd4yr
Copy link
Author

zsd4yr commented Oct 23, 2019

Thanks @nguerrera --sorry it's hard to keep track of where to make changes nowadays!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants