Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Add F# to dotnet cli 1..1.0#7024

Closed
KevinRansom wants to merge 1 commit intodotnet:masterfrom
KevinRansom:rel/1.1.0
Closed

Add F# to dotnet cli 1..1.0#7024
KevinRansom wants to merge 1 commit intodotnet:masterfrom
KevinRansom:rel/1.1.0

Conversation

@KevinRansom
Copy link
Copy Markdown

Add F# support into the dotnet sdk and dotnet cli 1.1.0

@dnfclas
Copy link
Copy Markdown

dnfclas commented Jun 29, 2017

@KevinRansom,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@KevinRansom
Copy link
Copy Markdown
Author

@livarcocc @nguerrera @srivatsn @cartermp @brettfo

Hey guys want to take a look at this please.

Comment thread Microsoft.DotNet.Cli.sln
@@ -1,7 +1,7 @@


This comment was marked as spam.

CrossgenPath="$(CrossgenPath)"
ReadyToRun="True"
PlatformAssemblyPaths="@(PlatformAssemblies);
PlatformAssemblyPaths="%(CrossgenTargets.RootDir)%(CrossgenTargets.Directory);

This comment was marked as spam.

<Copy SourceFiles="@(HackFilesToCopy)"
DestinationFiles="@(HackFilesToCopy->'$(PublishDir)/%(RecursiveDir)%(Filename)%(Extension)')" />
</Target>
<Target Name="MakeFscRunnableAndMoveToPublishDir"

This comment was marked as spam.

@livarcocc
Copy link
Copy Markdown

No tests for this new way of doing F#?

@livarcocc
Copy link
Copy Markdown

@KevinRansom This should not be targeting master. This needs to target rel/1.1.0.

@KevinRansom
Copy link
Copy Markdown
Author

@i will fix the targeting, no tests possible until the templates are updated. Then the existing tests should continue to work fine.

@KevinRansom
Copy link
Copy Markdown
Author

need to retarget.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants