Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Add F# to dotnet cli 1.1.0#7033

Merged
livarcocc merged 2 commits intodotnet:rel/1.1.0from
KevinRansom:rel/1.1.0
Jun 30, 2017
Merged

Add F# to dotnet cli 1.1.0#7033
livarcocc merged 2 commits intodotnet:rel/1.1.0from
KevinRansom:rel/1.1.0

Conversation

@KevinRansom
Copy link
Copy Markdown

@KevinRansom KevinRansom commented Jun 29, 2017

See also: #7024

@dnfclas
Copy link
Copy Markdown

dnfclas commented Jun 29, 2017

@KevinRansom,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@KevinRansom
Copy link
Copy Markdown
Author

KevinRansom commented Jun 29, 2017

@dotnet-bot test OSX10.12 x64 Release Build please

@KevinRansom
Copy link
Copy Markdown
Author

KevinRansom commented Jun 29, 2017

@dotnet-bot test Linux x64 Release Build please

@KevinRansom
Copy link
Copy Markdown
Author

KevinRansom commented Jun 29, 2017

@dotnet-bot test Linux x64 Release Build please

@KevinRansom
Copy link
Copy Markdown
Author

KevinRansom commented Jun 29, 2017

@dotnet-bot test this please

@nguerrera
Copy link
Copy Markdown
Contributor

nguerrera commented Jun 29, 2017

Fill out template and tag Matt

livarcocc
livarcocc reviewed Jun 29, 2017
View reviewed changes
Comment thread build/Microsoft.DotNet.Cli.Compile.targets
CrossgenPath="$(CrossgenPath)"
ReadyToRun="True"
PlatformAssemblyPaths="@(PlatformAssemblies);
PlatformAssemblyPaths="%(CrossgenTargets.RootDir)%(CrossgenTargets.Directory);

This comment was marked as spam.

Sign in to view

@nguerrera nguerrera changed the title Add F# to dotnet cli 1..1.0 Add F# to dotnet cli 1.1.0 Jun 29, 2017
@KevinRansom
Copy link
Copy Markdown
Author

KevinRansom commented Jun 29, 2017 •
edited
Loading

Tagging @MattGertz for approval pending CI tests.

Customer scenario: VS ships with the V1.1 sdk and dotnet CLI without this change netstandard libraries and apps will not be editable in VS.

Workarounds if any: Manually finding and installing dotnet sdk 2.0.

Risk: Low
Performance impact : None only enabled for .fsproj

Is this a regression from a previous update?:, dotnet core support hasn't been provided in the past.

Root cause analysis : Not yet implemented

How was this bug found? : Not yet implemented

@livarcocc livarcocc merged commit 13e84f7 into dotnet:rel/1.1.0 Jun 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@nguerrera nguerrera nguerrera approved these changes

@livarcocc livarcocc livarcocc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KevinRansom @dnfclas @nguerrera @livarcocc @MattGertz