This repository was archived by the owner on Apr 20, 2023. It is now read-only.
[New] Security build for CLI#7296
Merged
livarcocc merged 6 commits intodotnet:masterfrom Aug 1, 2017
Merged
Conversation
livarcocc
approved these changes
Jul 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting a fresh PR since the earlier one (#7076) has run into rebase-merge conflicts leading to lot of noise. All comments from that PR have been addressed.
Approach for CLI security build is:
dotnetcli/Sdk/<branch>sdkfolderlatest.versionfileVSTS build definition is at https://devdiv.visualstudio.com/DevDiv/_build/index?context=allDefinitions&path=%5CDotNet%5CSecurity&definitionId=6698&_a=completed
This invokes the build whose JSON is shown in this PR.
How to launch a security build is described at https://github.com/dotnet/core-eng/blob/master/Documentation/Project-Docs/security-builds.md
Running this build produced the following report - http://aztsa/api/Result/CodeBase/DotNet-CLI-Trusted_master/Summary
There are around 180 issues to triage -
https://msazure.visualstudio.com/DefaultCollection/One/_workitems?tempQueryId=740da6e8-15ce-4912-b983-2cf87ed6a530
@livarcocc please review.
Post merge I will log an issue to read latest build from https://dotnetcli.blob.core.windows.net/dotnet/Sdk/master/latest.version