This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Security build definition for CLI#7076
Closed
ravimeda wants to merge 267 commits intodotnet:masterfrom
Closed
Conversation
Revert "Pinning the SDK version to: "2.0.0-preview3-006628""
…upCrossgen229Coherence26027 Update to SetupCrossgen 229 - Coherence 26027
…-to-release/2.0.0-20170703-070029 * dotnet/rel/1.1.0: feedback Enable VB for dotnet cli 1.1 MSBuild 15.3.402 Add F# to dotnet cli 1..1.0
…/UpdateTemplateEngineFor1x Mlorbetske dev/mlorbe/update template engine for1x
…e/2.0.0-20170703-070029 Merge rel/1.1.0 to release/2.0.0
Update SDK to 2.0.0-preview3-20170703-2
Update runtime to 2.0.0-preview3-25502-01
Publishing a 'coherent' badge.
… 1.0.4 if the minimum SDK version file is not found.
…-to-release/2.0.0-20170705-070026 * dotnet/rel/1.1.0: Copy Paste error chmod .sh files Update the SDK to 1.1.0-alpha-20170630-2 Update Template Engine and templates for 1.x
…e/2.0.0-20170705-070026 Merge rel/1.1.0 to release/2.0.0
…upCrossgen246Coherence26065 Update to SetupCrossgen 249 - Coherence 26071
…ster-20170705-070028 Merge release/2.0.0 to master
Update compiler
…ster-20170725-070023 Merge release/2.0.0 to master
….0-to-release/2.0.0-20170725-070022
Updating the build definition URLs: master
Insert NuGet Build 4.3.0-rtm-4324 into cli
Use 2.1 builds for stage0 of 2.1 builds
…6452 updating to coherence 26452 & templating build 300
…e/2.0.0-20170725-070022 Merge rel/1.1.0 to release/2.0.0
…imestampPackages Switch to picking up the no-timestamp runtime store and package cache
This change disables security build task that remove non-CLI assemblies. Thereby, all assemblies are scanned, and issues logged through TSA. This means issues in assemblies not owned or produced by CLI, have to be resolved as Won't Fix so that TSA will not re-create these issues in future scans.
Passwords/keys should not be passed in the environment
…ster-20170726-070023 Merge release/2.0.0 to master
This change disables security build task that remove non-CLI assemblies. Thereby, all assemblies are scanned, and issues logged through TSA. This means issues in assemblies not owned or produced by CLI, have to be resolved as Won't Fix so that TSA will not re-create these issues in future scans.
Member
Author
|
Please ignore the noise. I'm trying to rebase and resolve merge conflicts. If it does not work, I'll send a fresh PR. |
Member
Author
|
Please use #7296 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to dotnet/core-setup#2722
The approach for acquiring official build blobs is different since CLI does not have a dependency dotnet/buildtools that offers reliable means to download Azure blobs.
Approach:
init-toolscommand to acquire BuildTools.dotnetcli/Sdk/<branch>. For Windows build, include only blobs with extension.zipor.exe.latest.version@morganbr list of issues found -
https://msazure.visualstudio.com/DefaultCollection/One/_workitems?tempQueryId=740da6e8-15ce-4912-b983-2cf87ed6a530
@livarcocc PTAL.
Post PR, I will update documentation for launching security build for CLI at https://github.com/dotnet/core-eng/blob/master/Documentation/Project-Docs/security-builds.md
https://github.com/dotnet/core-eng/issues/650