Remove one layer of abstraction and multiple intermediate types#2039
Closed
adamsitnik wants to merge 16 commits intodotnet:mainfrom
Closed
Remove one layer of abstraction and multiple intermediate types#2039adamsitnik wants to merge 16 commits intodotnet:mainfrom
adamsitnik wants to merge 16 commits intodotnet:mainfrom
Conversation
…tConversionResult
* rename ReportError to AddError * test coverage improvement (multiple errors for one result)
…one (20% perf gain on simple scenarios)
…should be None improve perf: don't use .Single as it's on hot path and here we know it's only 1 (Arity has been validated)
… tests passing again
remove null checks as it's internal API and we are covered by nullable annotations
…sponding ArgumentResult
Co-authored-by: Jon Sequeira <jonsequeira@gmail.com>
…mber of JITted types and allocated memory
Member
Author
|
Closing in favor of #2040 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's #2033 + one commit: 1aa6937 I did not want to include it in #2023 as it would make reviewing hard. I am going to make it a draft for now and make it ready for review when #2033 is merged.
Explanation: In #2033 I've moved most of the validation logic to the
CommandResult, makingParseResultVisitora very simple class. This included moving all hacks fromParseResultVisitorto earlier stages of parsing. Thanks to that, we can makeParseOperationcreateSymbolResultinstances directly, rather than creating intermediateSyntaxNodeinstaces and later lettingParseResultVisitorto map it toSymbolResultinstances.This has a really nice impact on startup performance. The number of JIT compiled methods drops from 221 to 198, the startup improves by 1-2ms for the simple case scenario.
The allocaitons drop is also very nice: few hundreds of bytes for simple scenario.