Remove one layer of abstraction and multiple intermediate types#2040
Merged
adamsitnik merged 2 commits intodotnet:mainfrom Feb 2, 2023
Merged
Remove one layer of abstraction and multiple intermediate types#2040adamsitnik merged 2 commits intodotnet:mainfrom
adamsitnik merged 2 commits intodotnet:mainfrom
Conversation
…mber of JITted types and allocated memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation: In #2033 I've moved most of the validation logic to the
CommandResult, makingParseResultVisitora very simple class. This included moving all hacks fromParseResultVisitorto earlier stages of parsing. Thanks to that, we can makeParseOperationcreateSymbolResultinstances directly, rather than creating intermediateSyntaxNodeinstaces and later lettingParseResultVisitorto map it toSymbolResultinstances.This has a really nice impact on startup performance. The number of JIT compiled methods drops from 221 to 198, the startup improves by 1-2ms for the simple case scenario.
The allocations drop is also very nice: few hundreds of bytes for simple scenario.