Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix build break by only publishing dotnet-deb-tool for ubuntu.14.04-x64.#1576

Merged
eerhardt merged 2 commits into
dotnet:masterfrom
eerhardt:deb-tool-prefercliruntime
Feb 22, 2017
Merged

Fix build break by only publishing dotnet-deb-tool for ubuntu.14.04-x64.#1576
eerhardt merged 2 commits into
dotnet:masterfrom
eerhardt:deb-tool-prefercliruntime

Conversation

@eerhardt
Copy link
Copy Markdown
Member

@eerhardt
Copy link
Copy Markdown
Member Author

test Ubuntu arm Release Build

@eerhardt
Copy link
Copy Markdown
Member Author

FYI - I also fixed the package version so it doesn't contain "-beta-beta-001234". See https://dotnet.myget.org/feed/cli-deps/package/nuget/dotnet-deb-tool.

@eerhardt
Copy link
Copy Markdown
Member Author

test Ubuntu arm Release Build

@eerhardt
Copy link
Copy Markdown
Member Author

@jyoungyun @gkhanna79 - do you know why the Ubuntu arm build is failing? Is it becuase of #1512?

I'd like to get my change in since the official builds are currently broken.

@jyoungyun
Copy link
Copy Markdown

@eerhardt This issue is not related to your patch. This failure issue will be resolved after merging #1572.

@@ -62,9 +62,13 @@ public static BuildTargetResult Publish(BuildTargetContext c)
[BuildPlatforms(BuildPlatform.Ubuntu, "14.04")]

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@eerhardt eerhardt force-pushed the deb-tool-prefercliruntime branch from 1378f68 to d4be5c4 Compare February 22, 2017 16:39
@eerhardt
Copy link
Copy Markdown
Member Author

@dagood - I changed the condition as suggested.

@eerhardt eerhardt merged commit 8a9ba6d into dotnet:master Feb 22, 2017
@eerhardt eerhardt deleted the deb-tool-prefercliruntime branch February 22, 2017 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants