Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[ARM/CI] Add ARM CI script for cross build#1512

Merged
gkhanna79 merged 1 commit into
dotnet:masterfrom
jyoungyun:arm/support_arm_ci_build
Feb 22, 2017
Merged

[ARM/CI] Add ARM CI script for cross build#1512
gkhanna79 merged 1 commit into
dotnet:masterfrom
jyoungyun:arm/support_arm_ci_build

Conversation

@jyoungyun
Copy link
Copy Markdown

@jyoungyun jyoungyun commented Feb 9, 2017 •
edited
Loading

@hqueue
Copy link
Copy Markdown
Member

hqueue commented Feb 9, 2017

Related PR for CoreCLR is available at dotnet/coreclr#9445

@hqueue
Copy link
Copy Markdown
Member

hqueue commented Feb 9, 2017

@dotnet-bot test ci please

@hqueue
Copy link
Copy Markdown
Member

hqueue commented Feb 9, 2017

@dotnet-bot test Ubuntu16.04 arm Release Build
@dotnet-bot test Tizen4.0.0 armel Release Build

@hqueue
Copy link
Copy Markdown
Member

hqueue commented Feb 9, 2017

@dotnet-bot skip ci test

gkhanna79
gkhanna79 reviewed Feb 16, 2017
View reviewed changes
Comment thread scripts/arm32_ci_script.sh Outdated
sudo chown -R $(id -u -n) cross/rootfs

# Cross building core-setup with rootfs in Docker
if [ "$__buildArch" == "arm" ]; then

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@jyoungyun jyoungyun force-pushed the arm/support_arm_ci_build branch from 6bd2e2e to 1c98d6b Compare February 20, 2017 04:31
@jyoungyun
Copy link
Copy Markdown
Author

jyoungyun commented Feb 20, 2017

@dotnet-bot help

1 similar comment
@jyoungyun
Copy link
Copy Markdown
Author

jyoungyun commented Feb 20, 2017

@dotnet-bot help

@jyoungyun
Copy link
Copy Markdown
Author

jyoungyun commented Feb 20, 2017

@dotnet-bot test ci please
@dotnet-bot test Ubuntu arm Release
@dotnet-bot test Ubuntu armel Release

@jyoungyun
Copy link
Copy Markdown
Author

jyoungyun commented Feb 20, 2017

@dotnet-bot test ci please
@dotnet-bot test Ubuntu arm Release
@dotnet-bot test Ubuntu armel Release

@hseok-oh
Copy link
Copy Markdown

hseok-oh commented Feb 20, 2017

@dotnet-bot test ci please
@dotnet-bot test Ubuntu arm Release Build please
@dotnet-bot test Ubuntu armel Release Build please

@hseok-oh
Copy link
Copy Markdown

hseok-oh commented Feb 20, 2017 •
edited
Loading

@jyoungyun @gkhanna79 It seems we cannot test newly defined job for arm/linux. If you want careful solution for CI machine, I suggest you to use step-by-step PR.

  1. 1st PR: define new ARM/Linux job in netci.groovy that call scripts/arm32_ci_script.sh, but do nothing in script.
  2. Next PR: modify scripts/arm32_ci_script.sh to build for arm/linux.

@jyoungyun
Copy link
Copy Markdown
Author

jyoungyun commented Feb 20, 2017

@hseok-oh Even though I make a seperate patch like your suggestion, but I'm still not sure that my changes about netci.groovy is working well. Is it okay if this patch pass 'dotnet_core-setup/master/GenPRTest/generator_prtest' build alone?

@jyoungyun jyoungyun force-pushed the arm/support_arm_ci_build branch from 1c98d6b to e7b051d Compare February 21, 2017 04:18
@jyoungyun
Copy link
Copy Markdown
Author

jyoungyun commented Feb 21, 2017

@dotnet-bot test ci please
@hseok-oh @gkhanna79 I modified this patch as following @hseok-oh 's comments. This patch is simply to add Ubuntu arm and Tizen armel CI job only and the arm32_ci script does nothing. PTAL

@jyoungyun jyoungyun changed the title [WIP][DO NOT MERGE][ARM/CI] Add ARM CI script for cross build [ARM/CI] Add ARM CI script for cross build Feb 21, 2017
@jyoungyun jyoungyun modified the milestone: 2.0.0 Feb 21, 2017
@jyoungyun
Add Ubuntu arm CI job
97733a9 
Implement ARM CI using Docker for arm
Call the arm32 CI script in netci.groovy but it is temporarily disabled
Uses 'arm-cross-latest' version image in Ubuntu14.04 machinemap
@jyoungyun jyoungyun force-pushed the arm/support_arm_ci_build branch from e7b051d to 97733a9 Compare February 21, 2017 10:38
@jyoungyun
Copy link
Copy Markdown
Author

jyoungyun commented Feb 21, 2017

@dotnet-bot test ci please

@jyoungyun
Copy link
Copy Markdown
Author

jyoungyun commented Feb 21, 2017 •
edited
Loading

@gkhanna79 @jashook @hqueue @hseok-oh @wateret And can I fix dotnet-ci like https://github.com/jyoungyun/dotnet-ci/blob/tizen/add_tizen_to_machine_map/jobs/generation/Utilities.groovy#L324L332 ? To use the Tizen os name, I must modify Jobs Utilities file.

@gkhanna79
Copy link
Copy Markdown
Member

gkhanna79 commented Feb 21, 2017

Change LGTM. Let me know when it is ready to merge @jyoungyun

@jyoungyun
Copy link
Copy Markdown
Author

jyoungyun commented Feb 22, 2017

@gkhanna79 It's okay to merge this PR. Thank you.

@gkhanna79 gkhanna79 merged commit b240389 into dotnet:master Feb 22, 2017
@gkhanna79
Copy link
Copy Markdown
Member

gkhanna79 commented Feb 22, 2017

@jyoungyun I have merged this. Can you please trigger a dummy pr to confirm that Linux Arm32 CI build looks good?

@jyoungyun jyoungyun mentioned this pull request Feb 22, 2017
Merged
@jyoungyun
Copy link
Copy Markdown
Author

jyoungyun commented Feb 22, 2017

@gkhanna79 I made a new PR(#1572) for confirming that ARM CI works well.

@eerhardt eerhardt mentioned this pull request Feb 22, 2017
Merged
This was referenced Feb 22, 2017
Merged
Merged
@hqueue hqueue mentioned this pull request Feb 28, 2017
Merged
@hqueue hqueue mentioned this pull request Jan 30, 2020
Closed
42 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gkhanna79 gkhanna79 gkhanna79 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jyoungyun @hqueue @hseok-oh @gkhanna79 @dnfclas