Remove dead HResults.cs#13611
Conversation
|
Should we rather change it other way around (delete |
|
OK, I changed to HResults, sorted, made case consistent, and combined into a single file, to match CoreRT. I'll put up a PR to do the same to CoreRT. After that, it can move into shared. |
| internal const int CORSEC_E_NO_EXEC_PERM = unchecked((int)0x80131418); | ||
| internal const int CORSEC_E_POLICY_EXCEPTION = unchecked((int)0x80131416); | ||
| internal const int CORSEC_E_SIGNATURE_MISMATCH = unchecked((int)0x80131420); | ||
| internal const int CORSEC_E_XMLSYNTAX = unchecked((int)0x80131419); |
There was a problem hiding this comment.
Some of these look unused, like CORSEC_E_XMLSYNTAX. It can be nice to have follow up cleanup.
There was a problem hiding this comment.
It is used in CoreRT in this file which also uses many others CoreCLR does not have. When I share the file in a later change, I will have to include them.
There was a problem hiding this comment.
I think S.P.Interop in CoreRT should keep own non-shared copy of the file.
There was a problem hiding this comment.
It may be useful to mark the eventual shared HResults as partial class so that different runtimes, different OSes, or different libraries can add to it own local codes.
* Fix old copy paste mistake * Remove dead HResults.cs * Rename __HResults to HResults * Rename other two __HResults classes * Combine into single HResults class, to match CoreRT * Make hex consistently uppercase * Sort HResults Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
4 participants
CoreRT is on the __HResults program as is most of the code.
I diffed HResults with __HResults and found a tpyo to fix also.