Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview2-25631-03, preview2-25631-02, preview2-25631-01, beta-25627-00, beta-25630-04, beta-25630-04, preview1-25631-01, respectively (master)

[dotnet-maestro-bot]

No description provided.

[stephentoub]

@dotnet-bot test OSX x64 Debug Build please (https://github.com/dotnet/corefx/issues/23585, https://github.com/dotnet/corefx/issues/23586)

[danmoseley]

OSX failures:

     System.Collections.Tests.BitArray_OperatorsTests.Xor_Operator(l: [False, True, False, True, False, ...], r: [True, False, True, False, True, ...], expected: [True, True, True, True, True, ...]) [FAIL]
        Assert.Equal() Failure
        Expected: True
        Actual:   False
        Stack Trace:
  downloaded dumpling.py
  total elapsed time 0:00:00.259832
           /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Collections/tests/BitArray/BitArray_OperatorsTests.cs(148,0): at System.Collections.Tests.BitArray_OperatorsTests.Xor_Operator(Boolean[] l, Boolean[] r, Boolean[] expected)


     System.Numerics.Tests.op_rightshiftTest.RunRightShiftTests [FAIL]
        Assert.Equal() Failure
                                         ↓ (pos 1463)
        Expected: ···7597549832185908496055652036397971206270186995006422806247374···
        Actual:   ···7597549832185908496044780019909157822739888180682011153420904···
                                         ↑ (pos 1463)
        Stack Trace:
  Starting:    System.Transactions.Local.Tests
           /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Runtime.Numerics/tests/BigInteger/op_rightshift.cs(167,0): at System.Numerics.Tests.op_rightshiftTest.VerifyRightShiftString(String opstring)
           /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Runtime.Numerics/tests/BigInteger/op_rightshift.cs(118,0): at System.Numerics.Tests.op_rightshiftTest.RunRightShiftTests()
     System.Numerics.Tests.op_xorTest.RunXorTests [FAIL]
        Assert.Equal() Failure
                                         ↓ (pos 211)
        Expected: ···6847719980645648242391560013772623448122857138198845994058095···
        Actual:   ···6847719980645648242352176967198432896670868764040813900469230···
                                         ↑ (pos 211)
        Stack Trace:
           /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Runtime.Numerics/tests/BigInteger/op_xor.cs(126,0): at System.Numerics.Tests.op_xorTest.VerifyXorString(String opstring)
           /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Runtime.Numerics/tests/BigInteger/op_xor.cs(77,0): at System.Numerics.Tests.op_xorTest.RunXorTests()
     System.Numerics.Tests.op_leftshiftTest.RunLeftShiftTests [FAIL]
        Assert.Equal() Failure
                                         ↓ (pos 3316)
        Expected: ···0517283663315453047755481119050449090694642926378640027906500···
        Actual:   ···0517283663315453047748047678874827853799207506142560881445391···
                                         ↑ (pos 3316)
        Stack Trace:
           /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Runtime.Numerics/tests/BigInteger/op_leftshift.cs(152,0): at System.Numerics.Tests.op_leftshiftTest.VerifyLeftShiftString(String opstring)
           /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Runtime.Numerics/tests/BigInteger/op_leftshift.cs(25,0): at System.Numerics.Tests.op_leftshiftTest.RunLeftShiftTests()
     System.Numerics.Tests.op_andTest.RunAndTests [FAIL]
        Assert.Equal() Failure
                                         ↓ (pos 1010)
        Expected: ···8803369220144527768004831472471606924705852257597538171155346···
        Actual:   ···8803369220144527768014836087551903544117475354180191951966556···
                                         ↑ (pos 1010)
        Stack Trace:
           /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Runtime.Numerics/tests/BigInteger/op_and.cs(126,0): at System.Numerics.Tests.op_andTest.VerifyAndString(String opstring)
           /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Runtime.Numerics/tests/BigInteger/op_and.cs(77,0): at System.Numerics.Tests.op_andTest.RunAndTests()

[danmoseley]

Win 10 x64 failures (note missing line numbers)

Unexpected Exception:Xunit.Sdk.TrueException: Assert.True() Failure
Expected: True
Actual:   False
   at Xunit.Assert.True(Nullable`1 condition, String userMessage)
   at System.Numerics.Tests.ToStringTest.VerifyToString(String test, String format, IFormatProvider provider, Boolean expectError, String expectedResult)
Expected: True
Actual:   False
Stack Trace :
   at System.Numerics.Tests.ToStringTest.VerifyToString(String test, String format, IFormatProvider provider, Boolean expectError, String expectedResult)
   at System.Numerics.Tests.ToStringTest.VerifyToString(String test, String format, String expectedResult)
   at System.Numerics.Tests.ToStringTest.RunStandardFormatToStringTests(Random random, String format, String negativeSign, Int32 precision, StringFormatter formatter)
   at System.Numerics.Tests.ToStringTest.RunRegionSpecificStandardFormatToStringTests()

[danmoseley]

Win10 Nano failure (maybe just flaky)

System.NullReferenceException : Object reference not set to an instance of an object.
Stack Trace :
   at MS.Internal.Xml.Cache.XPathNode.get_LocalNameHashCode()
   at MS.Internal.Xml.Cache.XPathDocumentBuilder.WriteStartElement(String prefix, String localName, String ns, String baseUri)
   at System.Xml.XPath.XPathDocument.LoadFromReader(XmlReader reader, XmlSpace space)
   at System.Xml.XPath.XPathDocument..ctor(XmlReader reader, XmlSpace space)
   at XPathTests.CreateNavigatorFromXmlReader.CreateNavigatorFromFile(String fileName)
   at XPathTests.Common.Utils.CreateNavigatorFromFile(String fileName)
   at XPathTests.Common.Utils.CreateNavigator(String xml, String startingNodePath, XmlNamespaceManager namespaceManager)
   at XPathTests.Common.Utils.XPathNodesetTest(String xml, String testExpression, XPathResult expected, XmlNamespaceManager namespaceManager, String startingNodePath)
   at XPathTests.FunctionalTests.Location.Paths.Predicates.UsingPositionFunctionTests.UsingPositionFunctionTest687()

@krwq any thoughts about the XPath failure above?

[danmoseley]

@ViktorHofer @mellinoe any thoughts about the BigInteger failures above?

Uh, I see @stephentoub opened issues for both, does that mean they repro without the new CLR?

[stephentoub]

does that mean they repro without the new CLR?

No, I opened those issues in response to this PR. But as this PR is about updating to a new coreclr, if tests in the repro are failing with this PR, that means either checked in tests are wrong or checked in coreclr code is wrong.

[danmoseley]

https://github.com/dotnet/corefx/issues/23585 suggests a GC hole. Perhaps the xpath one is also a GC hole symptom.

@swgillespie @jkotas what is the best way to narrow down a GC hole?

I will try see if I can repro locally.

[stephentoub]

Still waiting for a coreclr newer than preview2-25628-01...

[danmoseley]

build succeeded, hopefully it will kick this shortly

[danmoseley]

@mmitche did you get to add the logging?
https://ci3.dot.net/job/dotnet_corefx/job/master/job/windows-TGroup_all+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/2789/consoleText
[WS-CLEANUP] Deleting project workspace...Cannot delete workspace :remote file operation failed: D:\j\workspace\windows-TGrou---0d2c9ac4 at hudson.remoting.Channel@268def43:JNLP4-connect connection from 52.183.33.72/52.183.33.72:49174: java.io.IOException: Unable to delete 'D:\j\workspace\windows-TGrou---0d2c9ac4\Tools\net46\roslyn\tools\Microsoft.CodeAnalysis.CSharp.dll'.

[danmoseley]

@ahsonkhan @adriangodong is my build break fix correct? e360b05

[mmitche]

@danmosemsft That isn't an error at that point since not all processes are killed at that exact point (see message below that). However i would have expected that VCBSCompiler was the culrpit, and apparently not.

If you see this at the beginning of a job, that is a real issue.

[stephentoub]

Build is now broken due to dotnet/coreclr#13611. Fixing in dotnet/coreclr#13727.

[jkotas]

I have just pushed a fix here that does not require waiting for new CoreCLR build.

[stephentoub]

Thanks. Shall I close dotnet/coreclr#13727 then?

[jkotas]

I think so. The fewer places where S.R.WindowsRuntime depends on friend access to CoreLib the better.

[stephentoub]

I agree.