This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port rollback of System.IO DCR from release branch to master#23566
Merged
Conversation
safern
added
the
* NO MERGE *
Member
Author
|
This will need the updated coreclr with the port as well. Will throw a PR now. |
JeremyKuhne
suggested changes
Aug 26, 2017
Member
JeremyKuhne
left a comment
JeremyKuhne
left a comment
There was a problem hiding this comment.
Merge needs completed- see my comment.
| </Compile> | ||
| </ItemGroup> | ||
| <!-- Windows : Win32 only --> | ||
| <ItemGroup Condition="'$(TargetsWindows)' == 'true' and '$(UWPCompatible)' != 'true'"> |
Member
There was a problem hiding this comment.
The ItemGroup moved down- you should be able to remove 199-201.
Member
Author
There was a problem hiding this comment.
Oops, didn't see this conflict. Will fix it.
JeremyKuhne
approved these changes
Aug 26, 2017
Member
|
@dotnet-bot test this please (clr updated) |
Member
Author
|
I think clr was updated in rel/uwp6.0 but this PR is in master... we haven't gotten an updated clr into master since yesterday afternoon -- #23563 |
Member
|
@dotnet-bot test this please (new clr) |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…corefx#23566) * Port rollback of System.IO DCR from release branch to master Commit migrated from dotnet/corefx@7f1c480
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @danmosemsft @joshfree