This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Revert "Merge pull request #13245 from pgavlin/NoExpandIndex"#13682
Merged
Conversation
Member
Author
|
cc @pgavlin |
|
Why not just fix whatever the issue is? I can probably have a fix in by tomorrow. |
Member
Author
|
The change is causing bad GC info to be generated somewhere. I have not traced down where it is. I think it is going to take you more than a day to trace it down, fix it and do appropriate testing. CoreCLR ingestion into CoreFX has been blocked for 5 days because of this. It is important to get this unblocked because of things are pilling up. |
pgavlin
added a commit
that referenced
this pull request
Aug 31, 2017
Restore `GT_INDEX_ADDR` after #13682.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a7ffdec, reversing
changes made to f5f622d.