Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix P1 test build break#16631

Merged
jkotas merged 1 commit into
dotnet:masterfrom
jkotas:test-buildbreak
Feb 27, 2018
Merged

Fix P1 test build break#16631
jkotas merged 1 commit into
dotnet:masterfrom
jkotas:test-buildbreak

Conversation

@jkotas
Copy link
Copy Markdown
Member

@jkotas jkotas commented Feb 27, 2018

No description provided.

@tannergooding
Copy link
Copy Markdown
Member

Should we log a bug to add a CI leg that just builds, but does not run, the pri-1 tests by default (in order to catch changes like this)?

@jkotas
Copy link
Copy Markdown
Member Author

jkotas commented Feb 27, 2018

test Windows_NT x86 Checked jitnox86hwintrinsic

@jkotas jkotas merged commit 7eff571 into dotnet:master Feb 27, 2018
@jkotas
Copy link
Copy Markdown
Member Author

jkotas commented Feb 27, 2018

Should we log a bug to add a CI leg that just builds, but does not run, the pri-1 tests by default (in order to catch changes like this)?

I do think that this happens that often to be worth it.

A-And pushed a commit to A-And/coreclr that referenced this pull request Feb 28, 2018
@jkotas jkotas deleted the test-buildbreak branch March 1, 2018 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants