Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Delete left-over globalization CoreCLR tests#16571

Merged
jkotas merged 1 commit into
dotnet:masterfrom
jkotas:CoreCLRTestLibraryCleanup
Feb 27, 2018
Merged

Delete left-over globalization CoreCLR tests#16571
jkotas merged 1 commit into
dotnet:masterfrom
jkotas:CoreCLRTestLibraryCleanup

Conversation

@jkotas
Copy link
Copy Markdown
Member

@jkotas jkotas commented Feb 26, 2018

The legacy Globalization CoreCLR tests were deleted by #9322. This is deleting a few leftovers that I have run into.

@jkotas jkotas force-pushed the CoreCLRTestLibraryCleanup branch from 86e35b1 to 5c232d2 Compare February 26, 2018 17:42
@jkotas jkotas merged commit c41b6f0 into dotnet:master Feb 27, 2018
@jkotas jkotas deleted the CoreCLRTestLibraryCleanup branch February 27, 2018 15:29
@tannergooding
Copy link
Copy Markdown
Member

tannergooding commented Feb 27, 2018

@jkotas, this has broken several pri-1 tests. See the failures in #16558 for more details.

Ex: https://ci.dot.net/job/dotnet_coreclr/job/master/job/jitstress/job/x64_checked_windows_nt_jitincompletehwintrinsic_prtest/138/

error CS0117: 'Utilities' does not contain a definition for 'CompareBytes' [D:\j\workspace\x64_checked_w---1cba8152\tests\src\CoreMangLib\cti\system\convert\ConvertFromBase64String.csproj]

@jkotas
Copy link
Copy Markdown
Member Author

jkotas commented Feb 27, 2018

Fixed by #16631. I have not realized that the CI is not building all tests by default.

BruceForstall added a commit to BruceForstall/coreclr that referenced this pull request Mar 1, 2018
StringCompare1, StringCompare2, StringCompare15
BruceForstall added a commit that referenced this pull request Mar 2, 2018
…16688)

* Delete SingleGetHashCode and DoubleGetHashCode tests for arm/arm64

The tests themselves were deleted with #16567.

* Delete arm/arm64 tests deleted in #16571

StringCompare1, StringCompare2, StringCompare15

* Delete more references to these tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants