Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Delete Single/Double.GetHashCode tests#16567

Merged
jkotas merged 1 commit into
dotnet:masterfrom
jkotas:issue-16566
Feb 26, 2018
Merged

Delete Single/Double.GetHashCode tests#16567
jkotas merged 1 commit into
dotnet:masterfrom
jkotas:issue-16566

Conversation

@jkotas
Copy link
Copy Markdown
Member

@jkotas jkotas commented Feb 26, 2018

CoreFX has redundant and better test coverage for these.

Fixes #16566

@jkotas jkotas requested a review from tannergooding February 26, 2018 13:41
The test is failing because of change in the -NaN hashcode. CoreFX has redundant and better test coverage for these.

Fixes #16566
@jkotas jkotas changed the title Delete flaky Single/Double.GetHashCode tests Delete Single/Double.GetHashCode tests Feb 26, 2018
@tannergooding
Copy link
Copy Markdown
Member

Are the ARM jobs blocked due to the power outage? CC. @mmitche

@jkotas jkotas merged commit c431646 into dotnet:master Feb 26, 2018
@jkotas jkotas deleted the issue-16566 branch February 27, 2018 15:29
BruceForstall added a commit to BruceForstall/coreclr that referenced this pull request Mar 1, 2018
BruceForstall added a commit that referenced this pull request Mar 2, 2018
…16688)

* Delete SingleGetHashCode and DoubleGetHashCode tests for arm/arm64

The tests themselves were deleted with #16567.

* Delete arm/arm64 tests deleted in #16571

StringCompare1, StringCompare2, StringCompare15

* Delete more references to these tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants