Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Delete SingleGetHashCode and DoubleGetHashCode tests for arm/arm64#16688

Merged
BruceForstall merged 3 commits into
dotnet:masterfrom
BruceForstall:DeleteGetHashCodeTests
Mar 2, 2018
Merged

Delete SingleGetHashCode and DoubleGetHashCode tests for arm/arm64#16688
BruceForstall merged 3 commits into
dotnet:masterfrom
BruceForstall:DeleteGetHashCodeTests

Conversation

@BruceForstall
Copy link
Copy Markdown

The tests themselves were deleted with #16567.

@BruceForstall BruceForstall requested a review from jkotas March 1, 2018 18:10
@BruceForstall
Copy link
Copy Markdown
Author

cc @dotnet/arm32-contrib @dotnet/arm64-contrib

StringCompare1, StringCompare2, StringCompare15
@BruceForstall
Copy link
Copy Markdown
Author

Also delete StringCompare tests deleted with #16571

@sdmaclea
Copy link
Copy Markdown

sdmaclea commented Mar 1, 2018

Is there a reason we have to manually manage these lists for Arm64. Can the test list be updated automatically? At test runtime?

@BruceForstall
Copy link
Copy Markdown
Author

We could probably auto-create the lists with some automation -- @jashook has some automation to update them, but it hasn't been used in a while.

Ideally, we would create a single cross-platform test infrastructure so we wouldn't have all three (or more?) msbuild/xunit, runtest.sh, and smarty.

@BruceForstall
Copy link
Copy Markdown
Author

@dotnet-bot test Windows_NT arm Cross Checked normal Build and Test
@dotnet-bot test Windows_NT arm64 Cross Checked normal Build and Test

@BruceForstall
Copy link
Copy Markdown
Author

@dotnet-bot test Windows_NT arm Cross Checked normal Build and Test
@dotnet-bot test Windows_NT arm64 Cross Checked normal Build and Test

@BruceForstall
Copy link
Copy Markdown
Author

@dotnet-bot test Windows_NT arm Cross Checked normal Build and Test
@dotnet-bot test Windows_NT arm64 Cross Checked normal Build and Test

test Windows_NT armlb Cross Checked Innerloop Build and Test
test OSX10.12 x64 Checked Innerloop Build and Test

@BruceForstall BruceForstall merged commit f30d3a8 into dotnet:master Mar 2, 2018
@BruceForstall BruceForstall deleted the DeleteGetHashCodeTests branch March 2, 2018 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants