Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix legacy Globalization tests to work on Linux#9322

Merged
tarekgh merged 2 commits into
dotnet:masterfrom
tarekgh:FixMonthNamesTest
Feb 4, 2017
Merged

Fix legacy Globalization tests to work on Linux#9322
tarekgh merged 2 commits into
dotnet:masterfrom
tarekgh:FixMonthNamesTest

Conversation

@tarekgh
Copy link
Copy Markdown
Member

@tarekgh tarekgh commented Feb 3, 2017 •
edited
Loading

Fixes #9289

@tarekgh
Copy link
Copy Markdown
Member Author

tarekgh commented Feb 3, 2017

#9315

@tarekgh
Copy link
Copy Markdown
Member Author

tarekgh commented Feb 3, 2017

@AlexGhiondea could you please have a quick look? these are trivial test fixes

@tarekgh
Copy link
Copy Markdown
Member Author

tarekgh commented Feb 3, 2017

cc @wtgodbe

@wtgodbe
Copy link
Copy Markdown
Member

wtgodbe commented Feb 3, 2017

Did you confirm these tests pass on Ubuntu16.04 and Fedora23? Unfortunately we don't have CI support to run tests for those distros currently

@wtgodbe
Copy link
Copy Markdown
Member

wtgodbe commented Feb 3, 2017

Otherwise LGTM

@tarekgh
Copy link
Copy Markdown
Member Author

tarekgh commented Feb 3, 2017

Did you confirm these tests pass on Ubuntu16.04 and Fedora23? Unfortunately we don't have CI support to run tests for those distros currently

I confirmed on Ubuntu16.04 but it should pass now on Fedora23 too..

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Feb 4, 2017

Do we have appropriate coverage in corefx? If yet, can we delete these tests here? If not, we should add the coverage in corefx and delete these tests here.

@tarekgh
Copy link
Copy Markdown
Member Author

tarekgh commented Feb 4, 2017

Do we have appropriate coverage in corefx? If yet, can we delete these tests here? If not, we should add the coverage in corefx and delete these tests here.

we have good coverage on corefx. I thought we have these in coreclr just for basic validation before consuming coreclr on corefx. I am not sure who added these in the first place here.

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Feb 4, 2017

These tests were added in the early days when there was not a very good coordination. Folks were looking just at number of tests ported, without noticing that the same tests has been or are being ported in corefx repo as well...

@tarekgh
Copy link
Copy Markdown
Member Author

tarekgh commented Feb 4, 2017

ok, I'll go ahead and remove these.

@tarekgh
Copy link
Copy Markdown
Member Author

tarekgh commented Feb 4, 2017

@jkotas I have removed all globalization tests from coreclr. please let me know if you have any other comments. thanks

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Feb 4, 2017

Awesome! Thanks.

@tarekgh tarekgh merged commit e2f7e20 into dotnet:master Feb 4, 2017
jorive pushed a commit to guhuro/coreclr that referenced this pull request May 4, 2017
@tarekgh
Fix legacy Globalization tests to work on Linux (dotnet#9322)
f2ec080 
* Fix legacy Globalization tests to work on Linux

* Delete globalization tests
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
@jkotas jkotas mentioned this pull request Feb 26, 2018
Merged
@tarekgh tarekgh deleted the FixMonthNamesTest branch March 25, 2019 15:30
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@tarekgh
Fix legacy Globalization tests to work on Linux (dotnet/coreclr#9322)
d16b214 
* Fix legacy Globalization tests to work on Linux

* Delete globalization tests


Commit migrated from dotnet/coreclr@e2f7e20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jkotas jkotas jkotas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tarekgh @wtgodbe @jkotas @karelz @dnfclas