This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Mirror changes from dotnet/corefx#17709
Merged
Merged
Conversation
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
|
@ahsonkhan can you check if this mirrored PR changes are correct ? |
|
This is a change leftover from dotnet/corefx#28992, specifically the following commit: dotnet/corefx@95b8f31 We don't see any issues with this because the code path with the bug (which would throw null reference exception) is under @Anipik, are there any other missing commits? |
|
It looks like another changes is missing.
|
|
@ahsonkhan I think this was the only one. but I will look again for missing commits after this has been merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains mirrored changes from dotnet/corefx
Please REBASE this PR when merging