Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Update xml comment for {ReadOnly}Memory.Pin method#29137

Merged
ahsonkhan merged 1 commit into
dotnet:masterfrom
ahsonkhan:UpdatePinComment
Apr 16, 2018
Merged

Update xml comment for {ReadOnly}Memory.Pin method#29137
ahsonkhan merged 1 commit into
dotnet:masterfrom
ahsonkhan:UpdatePinComment

Conversation

@ahsonkhan
Copy link
Copy Markdown

@ahsonkhan ahsonkhan commented Apr 16, 2018

See dotnet/coreclr#17269 (comment) for context.

This will need to get mirrored to coreclr (cc @Anipik)

@ahsonkhan
Copy link
Copy Markdown
Author

@dotnet-bot test NETFX x86 Release Build
@dotnet-bot test Windows x64 Debug Build
@dotnet-bot test Windows x86 Release Build

@ahsonkhan
Copy link
Copy Markdown
Author

@dotnet-bot test Linux x64 Release Build
@dotnet-bot test NETFX x86 Release Build
@dotnet-bot test Windows x64 Debug Build
@dotnet-bot test Windows x86 Release Build

@ahsonkhan ahsonkhan merged commit 76e0104 into dotnet:master Apr 16, 2018
@ahsonkhan ahsonkhan deleted the UpdatePinComment branch April 16, 2018 08:54
@ahsonkhan
Copy link
Copy Markdown
Author

@Anipik, @safern - it looks like mirroring isn't working as expected (waiting on a mirror PR to coreclr).

@safern
Copy link
Copy Markdown
Member

safern commented Apr 16, 2018

It was stuck on a merge conflict -- just fixed it and it mirrored: dotnet/coreclr#17556 opening #29146 which was before this commit, so it should probably mirror this afterwards

dotnet-bot pushed a commit to dotnet/coreclr that referenced this pull request Apr 16, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
ahsonkhan pushed a commit to dotnet/coreclr that referenced this pull request Apr 16, 2018
…) (#17593)

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot added a commit to dotnet/corert that referenced this pull request Apr 17, 2018
…) (#17593)

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas pushed a commit to dotnet/corert that referenced this pull request Apr 17, 2018
…) (#17593)

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-bot pushed a commit to dotnet/coreclr that referenced this pull request Apr 20, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
ahsonkhan pushed a commit to dotnet/coreclr that referenced this pull request Apr 20, 2018
…) (#17709)

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
@karelz karelz added this to the 2.1.0 milestone Apr 21, 2018
@karelz
Copy link
Copy Markdown
Member

karelz commented Apr 25, 2018

Note: The change got into release/2.1 branch via last integration master->release/2.1 on 4/16.

dotnet-bot added a commit to dotnet/corert that referenced this pull request May 9, 2018
…) (#17709)

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas pushed a commit to dotnet/corert that referenced this pull request May 9, 2018
…) (#17709)

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants