Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Updating BuildDelayFreeUses to also consider contained HWIntrinsic nodes.#18120

Merged
tannergooding merged 1 commit into
dotnet:masterfrom
tannergooding:hwintrin-contain
May 24, 2018
Merged

Updating BuildDelayFreeUses to also consider contained HWIntrinsic nodes.#18120
tannergooding merged 1 commit into
dotnet:masterfrom
tannergooding:hwintrin-contain

Conversation

@tannergooding
Copy link
Copy Markdown
Member

@tannergooding tannergooding commented May 24, 2018

@tannergooding tannergooding requested a review from CarolEidt May 24, 2018 21:22
@tannergooding tannergooding mentioned this pull request May 24, 2018
Merged
@tannergooding
Copy link
Copy Markdown
Member Author

tannergooding commented May 24, 2018

@dotnet-bot test Windows_NT x64 Checked jitincompletehwintrinsic
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnosimd
@dotnet-bot test Windows_NT x64 Checked jitnox86hwintrinsic

@dotnet-bot test Windows_NT x86 Checked jitincompletehwintrinsic
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnosimd
@dotnet-bot test Windows_NT x86 Checked jitnox86hwintrinsic

@dotnet-bot test Ubuntu x64 Checked jitincompletehwintrinsic
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnosimd
@dotnet-bot test Ubuntu x64 Checked jitnox86hwintrinsic

CarolEidt
CarolEidt reviewed May 24, 2018
View reviewed changes
Copy link
Copy Markdown

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/jit/lsrabuild.cpp Outdated
setDelayFree(use);
return 1;
}
else if (node->OperIsHWIntrinsic())
Copy link
Copy Markdown

@CarolEidt CarolEidt May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: (And this applies to the existing id below) this doesn't need to be else if, as the clause above returns.

Copy link
Copy Markdown
Member Author

@tannergooding tannergooding May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix up after the tests finish, that way I don't need to requeue the outer-loop jobs again 😄

Copy link
Copy Markdown
Member Author

@tannergooding tannergooding May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@tannergooding tannergooding merged commit 3b32ecf into dotnet:master May 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@CarolEidt CarolEidt CarolEidt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HWIntrinsic failures for the RO tests when AVX disabled

2 participants

@tannergooding @CarolEidt