HWIntrinsic failures for the RO tests when AVX disabled

[tannergooding]

Several of the *_ro HWIntrinsic tests are failing with:

MESSAGE:
\r\nAssert failure(PID 3184 [0x00000c70], Thread: 6828 [0x1aac]): Assertion failed '(consume == 0) || (ComputeAvailableSrcCount(tree) == consume)' in 'JIT.HardwareIntrinsics.X86.SimpleBinaryOpTest__AddSingle:RunBasicScenario_LoadAligned():this' (IL size 100)\r\n\r\n File: d:\\j\\workspace\\x64_checked_w---c04c733a\\src\\jit\\lsrabuild.cpp Line: 1509\r\n Image: D:\\j\\workspace\\x64_checked_w---c04c733a\\bin\\tests\\Windows_NT.x64.Checked\\Tests\\Core_Root\\CoreRun.exe\r\n\r\n\n\nReturn code: 1\nRaw output file: D:\\j\\workspace\\x64_checked_w---c04c733a\\bin\\tests\\Windows_NT.x64.Checked\\Reports\\JIT.HardwareIntrinsics\\X86\\Sse\\Sse_ro\\Sse_ro.output.txt\nRaw output:\nBEGIN EXECUTION\r\n \"D:\\j\\workspace\\x64_checked_w---c04c733a\\tests\\..\\bin\\tests\\Windows_NT.x64.Checked\\Tests\\Core_Root\\corerun.exe\" Sse_ro.exe \r\nRunning Add.Single test...\r\nExpected: 100\r\nActual: 123456789\r\nEND EXECUTION - FAILED\r\nFAILED\r\nTest Harness Exitcode is : 1\r\n\nTo run the test:\n> set CORE_ROOT=D:\\j\\workspace\\x64_checked_w---c04c733a\\bin\\tests\\Windows_NT.x64.Checked\\Tests\\Core_Root\n> D:\\j\\workspace\\x64_checked_w---c04c733a\\bin\\tests\\Windows_NT.x64.Checked\\JIT\\HardwareIntrinsics\\X86\\Sse\\Sse_ro\\Sse_ro.cmd\n\r\nExpected: True\r\nActual: False
+++++++++++++++++++
STACK TRACE:
at JIT_HardwareIntrinsics._X86_Sse_Sse_ro_Sse_ro_._X86_Sse_Sse_ro_Sse_ro_cmd() in D:\j\workspace\x64_checked_w---c04c733a\bin\tests\Windows_NT.x64.Checked\TestWrappers\JIT.HardwareIntrinsics\JIT.HardwareIntrinsics.XUnitWrapper.cs:line 24187

Ex: https://ci.dot.net/job/dotnet_coreclr/job/master/job/jitstress/job/x64_checked_windows_nt_jitx86hwintrinsicnoavx_prtest/247/

See dotnet/coreclr#18105 for more jobs

[tannergooding]

Looking at the commit jobs (ex: https://ci.dot.net/job/dotnet_coreclr/job/master/job/jitstress/job/x64_checked_windows_nt_jitx86hwintrinsicnoavx/131/), this looks to be caused by dotnet/coreclr#16517.

The only other change to the lsraxarch.cpp file so far is dotnet/coreclr#18078, but that wasn't committed as of the above failure.

[tannergooding]

CC. @CarolEidt

[tannergooding]

Also CC. @fiigii, @eerhardt as an FYI

[tannergooding]

@CarolEidt, I see the problem.

In BuildDelayFreeUses (any possibly some of the other new functions) it is always returning 0 for a contained node which isn't an Indir. However, certain HWIntrinsic nodes can be marked as contained and still need their operands counted (I believe we talked previously about turning these into actual Indir nodes, but that hasn't happened yet).

[tannergooding]

PR resolving the issue is here: dotnet/coreclr#18120